-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make notEqual work on relations #1350
Conversation
8fc2451
to
20a70ea
Compare
Current coverage is
|
This looks like it's going to not work if you use mix and match equalTo, notEqualtTo, containedIn, and notContainedIn all in the same query. Have you checked for that? |
@drew-gross yes you're definitely right, I didn't check for that. I'll need to map on all $eq, $ne, $in, $nin |
Hey, @drew-gross yes, it was another consequences of my further tests (that I just finished now (you were quicker)), the server do not like the combinations as well. Do you need some further test cases to fix that quicker? When do you think it could go live? |
@lolobosse I think @flovilmart is already working on this, but If you posted a test case similar to the one in this PR, he would probably find that helpful! |
@drew-gross I posted the support, let me know what you think |
This looks like it should do the trick 💯 |
Adds support for $eq, $ne and $nin when querying on relation keys