Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update foundation sass settings, foundation sites #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sandeepsajan0
Copy link
Collaborator

Description

Upgrade the foundation to the latest version
Close #9

Rationale

Use case(s) / visualization(s)

@sandeepsajan0
Copy link
Collaborator Author

I have put only vendors and scss in foundation sites but paste what-input whole as I get from new foundation project.

@sandeepsajan0 sandeepsajan0 requested a review from Parbhat January 8, 2020 05:00
Copy link
Owner

@Parbhat Parbhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting the following error visiting the Homepage

CompileError at /
Error: File to import not found or unreadable: util/util.
        on line 63:1 of dj_foundation_training/static/sass/_settings.scss
        from line 3:1 of dj_foundation_training/static/sass/app.scss
>> @import 'util/util';

We will also need these changes:

  1. Update Foundation JS to latest version

    <script src="https://cdnjs.cloudflare.com/ajax/libs/foundation/6.4.3/js/foundation.min.js"></script>

  2. It is not required to copy complete what-input directory. Only need the what-input.min.js

    <script src="{% static 'libs/what-input/what-input.min.js' %}"></script>

  3. Also, update JQuery to the latest version supported by Foundation

    <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js"></script>

  4. We are not including Motion UI by default. So, we can turn off it as well.

@sandeepsajan0
Copy link
Collaborator Author

sandeepsajan0 commented Jan 14, 2020

Foundation sites version 6.6.1 have compiling issue with libsass version 0.19.4 specifically here with "solid' style.
So, We have decided to use 6.5.3(foundation-sites) with the latest version of libsass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to latest Foundation framework (6.6)
2 participants