-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update foundation sass settings, foundation sites #12
base: master
Are you sure you want to change the base?
Conversation
I have put only vendors and scss in foundation sites but paste what-input whole as I get from new foundation project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting the following error visiting the Homepage
CompileError at /
Error: File to import not found or unreadable: util/util.
on line 63:1 of dj_foundation_training/static/sass/_settings.scss
from line 3:1 of dj_foundation_training/static/sass/app.scss
>> @import 'util/util';
We will also need these changes:
-
Update Foundation JS to latest version
Line 128 in a5929a3
<script src="https://cdnjs.cloudflare.com/ajax/libs/foundation/6.4.3/js/foundation.min.js"></script> -
It is not required to copy complete
what-input
directory. Only need the what-input.min.js
Line 127 in a5929a3
<script src="{% static 'libs/what-input/what-input.min.js' %}"></script> -
Also, update JQuery to the latest version supported by Foundation
Line 126 in a5929a3
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.2.1/jquery.min.js"></script> -
We are not including Motion UI by default. So, we can turn off it as well.
Foundation sites version 6.6.1 have compiling issue with libsass version 0.19.4 specifically here with "solid' style. |
Description
Upgrade the foundation to the latest version
Close #9
Rationale
Use case(s) / visualization(s)