-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Read Gitlab server URL from env for prime integrations #9910
Conversation
Right now it is hardcoded, but private Gitlab instances behave like the public one, so for some Parabol instances it might make sense to point it to a different Gitlab instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my inline comment, LGTM.
This would be a great use case for you to test the process of adding a new environment variable to the application 😸 You have Loom videos and documentation explaining how to do it, but please, let me know if you need any help with that 😃
@@ -8,7 +8,7 @@ const upsertGlobalIntegrationProvidersFromEnv = async () => { | |||
authStrategy: 'oauth2', | |||
scope: 'global', | |||
teamId: 'aGhostTeam', | |||
serverBaseUrl: 'https://gitlab.com', | |||
serverBaseUrl: process.env.GITLAB_SERVER_URL ?? 'https://gitlab.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a default value? IMHO we should just use the env GITLAB_SERVER_URL and on the .env.example we can have our default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not want to touch the current deployments without any need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's true that removing that default value is a breaking change. Ok, let's keep it there.
I'm just against default hardcoded values in general 😸
Description
Right now it is hardcoded, but private Gitlab instances behave like the public one, so for some Parabol instances it might make sense to point it to a different Gitlab instance.
Demo
https://www.loom.com/share/bd9d06ef81b74f74b46ca2e80af04383?sid=3e3369ab-3e94-4d7e-8fb2-7d960cffe032 🔒
Testing scenarios
yarn build && yarn predeploy
Final checklist