Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: User can change team in Activity Library #9893

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

Dschoordsch
Copy link
Contributor

Description

Fixes #9892
Menu items were not properly nested because I did not retest #9679 with latest master before merging.

Demo

[If possible, please include a screenshot or gif/video, it'll make it easier for reviewers to understand the scope of the changes and how the change is supposed to work. If you're introducing something new or changing the existing patterns, please share a Loom and explain what decisions you've made and under what circumstances]

Testing scenarios

  • Activity library switch teams
  • clone template and chose team
  • click on active meetings dropdown

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

🎵 Yo, yo, listen up, here's the scoop,
Use MenuItem within MenuContent, that's the truth.
Don't break the rules, follow the flow,
And your code will work without an error show. 🎵
Copy link
Contributor

@nickoferrall nickoferrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works!

@Dschoordsch Dschoordsch merged commit ce7e8bb into master Jun 27, 2024
6 checks passed
@Dschoordsch Dschoordsch deleted the fix/9892/newMeetingTeamPicker branch June 27, 2024 14:17
@github-actions github-actions bot mentioned this pull request Jun 27, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cannot switch teams in AL
2 participants