Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide ai icebreaker ui for non ai users #9824

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

nickoferrall
Copy link
Contributor

Fix #9821

The noAISummary feature flag is useful for disabling AI features for users who don't want them (it should probably be renamed to noAI).

But we should also have an endpoint that lets the client know if the server doesn't have access to OpenAI.

AC

  • Remove access to OpenAI and see that the AI Icebreaker UI doesn't show up

@@ -60,6 +60,7 @@ const rewriteIndexHTML = () => {
stripe: process.env.STRIPE_PUBLISHABLE_KEY,
publicPath: __webpack_public_path__,
oauth2Redirect: process.env.OAUTH2_REDIRECT,
openAI: process.env.OPEN_AI_API_KEY,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-2 please correct me if i'm wrong, but isn't this a secret key?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is - we could make openAI a boolean and check if the key exists?

@github-actions github-actions bot added size/xs and removed size/s labels Jun 7, 2024
@nickoferrall nickoferrall requested review from mattkrick and Dschoordsch and removed request for mattkrick June 7, 2024 12:27
packages/client/types/modules.d.ts Outdated Show resolved Hide resolved
@nickoferrall nickoferrall merged commit 6cf4098 into master Jun 11, 2024
5 checks passed
@nickoferrall nickoferrall deleted the fix/9821/hide-ai-icebreaker-ui-for-non-ai-users branch June 11, 2024 14:57
@github-actions github-actions bot mentioned this pull request Jun 24, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove AI Icebreaker UI for users that don't have access to OpenAI
3 participants