-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor new meeting team dropdown #9679
Conversation
f48d877
to
f0389d2
Compare
There is a use case missing: we had logic to share a team template to the org when the team is switched and the template was scoped to the team. However this wouldn't work when the teams are not on the same org at all and there seems to be no check for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the first menu is actually an issue in production. FYI - I've refactored the Menu component slightly in this PR: https://github.com/ParabolInc/parabol/pull/9844/files#diff-e66f67ab51e485a12ee1b7f5726d1dfdc29fb01b119ec1465072350fa4527f84 Moving |
Description
Fixes #9274
Refactor the meeting select dropdown
Demo
https://www.loom.com/share/036fa7c85f584dd9a49c01ae1c4e2812?sid=9d0ebe45-aa8c-458e-b155-5dbc88b02734
Testing scenarios
Final checklist