Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve Activity Library focus and hover states #9626

Merged
merged 7 commits into from
Apr 16, 2024

Conversation

Dschoordsch
Copy link
Contributor

Description

Fixes #9200

Demo

https://www.loom.com/share/8e5e9498c8594056a0b4bc0ab2b70919?sid=394eacdb-589c-4ac1-a0d4-0d5ba6134845

Testing scenarios

  • focus and highlights in activity library
  • create custom activity card
  • create custom activity choose template screen

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

Copy link
Member

@ackernaut ackernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, Georg! I left a comment on the Loom about one small nuance for spacing below the text of the format selection sections. Not a blocker, but nice to refine.

@Dschoordsch Dschoordsch merged commit 6f1c1d9 into master Apr 16, 2024
5 checks passed
@Dschoordsch Dschoordsch deleted the chore/9200/improveActivityLibraryFocusHighlights branch April 16, 2024 08:26
@Dschoordsch
Copy link
Contributor Author

I've added some more padding there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity Library v2: Handle hover & focus states
4 participants