Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(release): Test v7.22.2 #9546

Merged
merged 74 commits into from
Mar 19, 2024
Merged

chore(release): Test v7.22.2 #9546

merged 74 commits into from
Mar 19, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Production Job Id: 6421408751
Staging Job Id: 6421408728

The basics

Run through this list at least once at staging:

  • Smoke tested the Demo, unauthenticated
  • Created an account
  • Verified invite via mass link works (Team > Invite Button > Invite Link, visit URL in an incognito window)
  • Verified invite via email works. It will show as logs in Datadog.
  • Added Slack, verified meeting notifications (use #t_product_actiontime)
  • Added Mattermost, verified meeting notifications (check the test webhook in Parabol Mattermost)
  • Added GitHub, verified issue created (use ParabolInc/publictestrepo)
  • Added Jira, verified issue created (use parabol-2)
  • Added GitLab, verified issue created
  • Added JiraServer, verified issue created
  • Smoke tested the Retro meeting with 2 players
  • Smoke tested the Sprint Poker meeting with 2 players
  • Smoke tested the Team Check-in meeting with 2 players
  • Smoke tested the Standup meeting with 2 players
  • Smoke tested cards on the dashboard
  • Created a 2nd team
  • Created a 2nd organization
  • Upgraded to Team (Credit card number: 4242 4242 4242 4242, expiration date: any month in the future, CVC: 123)
  • Upgraded to Team with a 3D Secure card (Credit card number: 4000 0000 0000 3220, expiration date: any month in the future, CVC: 123)
  • Tried and failed to upgrade with a card with insufficient funds (Credit card number: 4000 0000 0000 9995, expiration date: any month in the future, CVC: 123). Error feedback is shown in the UI.
  • Smoke tested the app on a mobile device (e.g. navigate between views, smoke test a Retro meeting, etc.)
  • Test previously existed meetings to make sure that existing data is not corrupted
  • Create a task in the discussion thread of a meeting
  • Create a comment in the discussion thread of a meeting

What’s changed

At your discretion, complete the tests for any merged PRs:

  • List each PR with a header and link to ([title], #[issue id])
  • Copy and paste tests, or note what was tested, in this issue
  • Run the equivalent test on staging that you would run in a local environment as closely as possible (e.g. updating the database to simulate cases, etc.)

Fixed

  • Only read the first ip of the x-forwarded-for header (#9545) (081f7a0)
  • snyk-ci: removed toLowerCase function as it does not exit (2c98ca1)
  • use base ref for migrition order check (#9542) (0217e11)

Changed

  • add GH Action, on Snyk PRs commit yarn.lock (#9534) (bd907a9)

@rafaelromcar-parabol
chore(env vars): Stripe vars moved to the Integrations section (#9427)
a0af0c1
@Dschoordsch
chore: fix misleading isLead field name on Team (#9413)
c0a2fdf 
* chore: fix misleading `isLead` field name on `Team`

The field indicates whether the viewer is the lead, but when used in a
query for a different user, the result could be read wrong.

* Fix Team.isLead dependencies
@nickoferrall
feat: remove team template limit (#9424)
f042628 
* update error message and increase template limit

* remove max team template limits

* remove canClone prop from CloneTemplate

* remove unused threshold

* remove unused threshold
@Dschoordsch
feat: Add Google calendar meeting series for recurrence (#9380)
02dc6fa 
* feat: Add recurrence to GCal events

* Fun with timezones
@Dschoordsch
fix: Increase the number of projects fetched per request from Atlassi…
b0b76f9 
…an (#9435)

We ran into timeouts in `getAllProjects`, presumably because we're doing
too many roundtrips. As a quick fix, increse the number of projects
fetched per request from 50 to 500.
@dependabot
chore(deps): bump ip from 1.1.8 to 1.1.9 (#9442)
c2a31e6 
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9.
- [Commits](indutny/node-ip@v1.1.8...v1.1.9)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@parabol-release-bot
chore(release): release v7.17.0 (#9428)
e4a831a 
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
@rafaelromcar-parabol
feat(standalone-deployment): Standalone host deployment improved and …
61ba015 
…documented (#9445)

* Docker compose stack improved

* Remove unused containers from docker-compse and add useful comment on .env.example about PGSSLMODE

* Docker compose profiles added. Documentation extended on how to use the profiles to manage the stack.

* README fixed as docker compose up and down commands were not working

* Typo fixed and docker-compose command replaced by docker compose
@mattkrick
feat: support env-defined saml issuer for PPMIs (#9455)
92ab5be 
* feat: support env-defined saml issuer for PPMIs

Signed-off-by: Matt Krick <[email protected]>

* feat: support single SAML for entire tenant

Signed-off-by: Matt Krick <[email protected]>

---------

Signed-off-by: Matt Krick <[email protected]>
@Dschoordsch
chore: Associate logs with traces (#9444)
c77925b 
* chore: Associate logs with traces

Add trace information to log output for server side log statements. This
does not include logging from code exclusively used for debugging,
deploying or development.

* Actually add the logger

* Fix DD_LOGS_INJECTION check
@parabol-release-bot
chore(release): release v7.18.0 (#9450)
bd519c9 
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
@mattkrick
chore: no force-push to prod (#9401)
6d46e1b 
Signed-off-by: Matt Krick <[email protected]>
@parabol-release-bot
chore(release): release v7.18.1 (#9459)
b60ff4e 
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
@jordanh @mattkrick
feat: embedder service (#9417)
55faa17 
* feat: add embedder service

---------

Signed-off-by: Matt Krick <[email protected]>
Co-authored-by: Matt Krick <[email protected]>
@mattkrick
merge production to avoid force push (#9461)
1008578 
Signed-off-by: Matt Krick <[email protected]>
@parabol-release-bot
chore(release): release v7.19.0 (#9460)
20ca927 
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
@mattkrick
fix: checkout prod before merging it (#9463)
7bd8803 
Signed-off-by: Matt Krick <[email protected]>
@parabol-release-bot
chore(release): release v7.19.1 (#9464)
12ba80e 
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
@mattkrick
fix: mrege origin/production strategy (#9465)
9e90b9d 
Signed-off-by: Matt Krick <[email protected]>
@parabol-release-bot
chore(release): release v7.19.2 (#9466)
e67ca91 
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
@mattkrick
fix: force push 5 (#9467)
581f0cf 
Signed-off-by: Matt Krick <[email protected]>
@parabol-release-bot
chore(release): release v7.19.3 (#9468)
b52faf2 
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
@nickoferrall
fix: limit invites from spammers (#9416)
5b9526c 
* fix: limit invites from spammers

* update where we check pending emails

* check total plus pending invites

* use invitees instead of pending
@Dschoordsch
fix: Fetch Jira projects in parallel (#9456)
9cec00a 
Previously we tried to fetch more projects per page, but Jira only ever
returns 50 max. Instead once we know how many projects there are after
fetching the first page, we fetch all remaining pages in parallel.
@mattkrick
fix: replace lone surrogates in draft-js content (#9415)
00092ec 
* fix: replace lone surrogates in draft-js content

Signed-off-by: Matt Krick <[email protected]>

* fix typo

Signed-off-by: Matt Krick <[email protected]>

* fix: eslint errors

Signed-off-by: Matt Krick <[email protected]>

---------

Signed-off-by: Matt Krick <[email protected]>
@dependabot
chore(deps): bump es5-ext from 0.10.62 to 0.10.64 (#9457)
92f0be9 
Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.62 to 0.10.64.
- [Release notes](https://github.com/medikoo/es5-ext/releases)
- [Changelog](https://github.com/medikoo/es5-ext/blob/main/CHANGELOG.md)
- [Commits](medikoo/es5-ext@v0.10.62...v0.10.64)

---
updated-dependencies:
- dependency-name: es5-ext
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@adaniels-parabol @snyk-bot
fix: packages/server/package.json to reduce vulnerabilities (#9434)
1e0075e 
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-UNDICI-6252336

Co-authored-by: snyk-bot <[email protected]>
@adaniels-parabol @snyk-bot
fix: packages/server/package.json to reduce vulnerabilities (#9392)
fd833f5 
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-NODEMAILER-6219989

Co-authored-by: snyk-bot <[email protected]>
@adaniels-parabol @snyk-bot
fix: packages/server/package.json to reduce vulnerabilities (#9298)
fd75d3f 
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-FOLLOWREDIRECTS-6141137

Co-authored-by: snyk-bot <[email protected]>
@dependabot @mattkrick
chore(deps): bump follow-redirects from 1.14.8 to 1.15.4 (#9312)
9441b27 
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.8 to 1.15.4.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.14.8...v1.15.4)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Matt Krick <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt Krick <[email protected]>
rafaelromcar-parabol and others added 22 commits March 6, 2024 18:04
@rafaelromcar-parabol
chore(gh-actions): reporting status to Slack if test or build GH Acti…
e7539d1 
…ons fail (#9512)

* chore(gh-actions): reporting status to Slack if test or build GH Actions fail

* chore: remove master branch from the if of report status on the build action, as it only runs  on release-please branches
@Dschoordsch
feat: Add team sections to the Custom category in activity library (#…
2338414 
…9511)

* feat: Add team sections to the Custom category in activity library

* Clean up create custom activity card
@mattkrick
fix: recreate lockfile (#9516)
af47966 
Signed-off-by: Matt Krick <[email protected]>
@BartoszJarocki @mwermuth @jordanh
feat: managing teams (#9285)
f351cf9 
Co-authored-by: Marcus Wermuth <[email protected]>
Co-authored-by: Jordan Husney <[email protected]>
@rafaelromcar-parabol
chore(ci): add capability to manually generate Docker Images (#9524)
88bf97f
@Dschoordsch
fix: Make hasGCalError optional (#9526)
9350b93
@Dschoordsch
chore: Remove Add Activity button from discussions (#9528)
37bd20c
@jordanh
fix: Korean greeting corrected (#9525)
10c6f69 
eat: added additional greetings
feat: added additinal check-in questions
@Dschoordsch
feat: Recurring GCal event dialog (#9506)
fc4429c
@Dschoordsch
feat: Release MS Teams integration (#9527)
1ed2796
@parabol-release-bot
chore(release): release v7.22.0 (#9513)
470e017 
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
@Dschoordsch
lint exceptions
c417b45
@jordanh
chore: migrate FailedAuthRequest to pg (#9500)
efc0dc9
@jordanh
chore: migrate ScheduledJob from rethinkdb to pg (#9490)
5c39fde
@mattkrick
fix: node-loader that ignores public path (#9537)
1009ede 
Signed-off-by: Matt Krick <[email protected]>
@parabol-release-bot
chore(release): release v7.22.1 (#9535)
09302e6 
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
@jordanh
chore: add GH Action, on Snyk PRs commit yarn.lock (#9534)
bd907a9
@rafaelromcar-parabol
fix(snyk-ci): removed toLowerCase function as it does not exit
2c98ca1
@Dschoordsch
fix: use base ref for migrition order check (#9542)
0217e11
@Dschoordsch
fix: Only read the first ip of the x-forwarded-for header (#9545)
081f7a0
@parabol-release-bot
chore(release): release v7.22.2 (#9539)
66b0960 
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
Merge remote-tracking branch 'origin/production' into release/v7.22.2
a3f00a1
@Dschoordsch Dschoordsch mentioned this pull request Mar 18, 2024
Closed
24 tasks
@MindEvo
Copy link
Contributor

MindEvo commented Mar 18, 2024 •
edited
Loading

Notes

  • New accounts/users are not able to see the images on the activities/meeting selection screen.

The basics

Run through this list at least once at staging:

  • Smoke tested the Demo, unauthenticated
  • Created an account
  • Verified invite via mass link works (Team > Invite Button > Invite Link, visit URL in an incognito window)
  • Verified invite via email works. It will show as logs in Datadog.
  • Added Slack, verified meeting notifications (use #t_product_actiontime)
  • Added Mattermost, verified meeting notifications (check the test webhook in Parabol Mattermost)
  • Added GitHub, verified issue created (use ParabolInc/publictestrepo)
  • Added Jira, verified issue created (use parabol-2)
  • Added GitLab, verified issue created
  • Added JiraServer, verified issue created
  • Smoke tested the Retro meeting with 2 players
  • Smoke tested the Sprint Poker meeting with 2 players
  • Smoke tested the Team Check-in meeting with 2 players
  • Smoke tested the Standup meeting with 2 players
  • Smoke tested cards on the dashboard
  • Created a 2nd team
  • Created a 2nd organization
  • Upgraded to Team (Credit card number: 4242 4242 4242 4242, expiration date: any month in the future, CVC: 123)
  • Upgraded to Team with a 3D Secure card (Credit card number: 4000 0000 0000 3220, expiration date: any month in the future, CVC: 123)
  • Tried and failed to upgrade with a card with insufficient funds (Credit card number: 4000 0000 0000 9995, expiration date: any month in the future, CVC: 123). Error feedback is shown in the UI.
  • Smoke tested the app on a mobile device (e.g. navigate between views, smoke test a Retro meeting, etc.)
  • Test previously existed meetings to make sure that existing data is not corrupted
  • Create a task in the discussion thread of a meeting
  • Create a comment in the discussion thread of a meeting

@Dschoordsch
Copy link
Contributor

I could reproduce the missing image issue only on Firefox, not on Chrome or Safari. @MindEvo which browser were you using?
I see the same issue on production, so I will continue with the release and immediately look into this issue.

@Dschoordsch Dschoordsch merged commit 5afdbba into production Mar 19, 2024
1 check passed
@Dschoordsch Dschoordsch deleted the release/v7.22.2 branch March 19, 2024 13:45
@MindEvo
Copy link
Contributor

MindEvo commented Mar 19, 2024

@Dschoordsch I saw it on Firefox and Edge.

@Dschoordsch
Copy link
Contributor

I cannot reproduce the issue on Edge (on Mac and Windows). I also would expect it to have the same behaviour as Chrome.
I have a fix for Firefox I try to release today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Dschoordsch Dschoordsch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@MindEvo @Dschoordsch @rafaelromcar-parabol @nickoferrall @mattkrick @jordanh @adaniels-parabol @dbumblis-parabol @BartoszJarocki