feat: show default insight

[nickoferrall]

Fix #10239

You could test this PR by connecting to staging and running generateInsight from graphiql. However, I suggest just reviewing the code as we'll only release this to Parabol to start with once the team feature flag is ready.

In the next PR, I'll create an empty state where you can generate an insight if one doesn't exist.

[nickoferrall]

I updated this as link-style is being used in two places now, not just the summary

[nickoferrall]

When the team feature flag is ready, I'll add a check for this too

[nickoferrall]

I'll add empty state soon (#10281) so there's no need to check if insights is null

[nickoferrall]

The design shows "this team" but I changed that to "name" as it's more personalised

[nickoferrall]

I'm getting a type error. The problem seems to be that the id is an Int because I'm using SERIAL here.

Insight.id is defined as type ID here.

But I get a type error, that's resolved when I do:

  insight: async ({id: teamId}, _args, {dataLoader}) => {
    const insight = await dataLoader.get('latestInsightByTeamId').load(teamId)
    if (!insight) return null
    return {
      ...insight,
      id: 'hey'
    }
  }

So the problem seems to be the id is an int, but it's expecting a string. I could change the type Insight.id to Int here, but that doesn't seem clean when it's an ID.

Any ideas?

[Dschoordsch]

-1 Yes, the type error is correct and caught an error. We don't want to return the database id directly (of type int) because IDs should be globally unique (something to do with Relay caching). So we should create an GQL ID type for insights where we do the usual join/split and something like insights:${teamId}:${databaseId}.

[nickoferrall]

Ah that makes sense, thanks!

[Dschoordsch]

-1 Yes, the type error is correct and caught an error. We don't want to return the database id directly (of type int) because IDs should be globally unique (something to do with Relay caching). So we should create an GQL ID type for insights where we do the usual join/split and something like insights:${teamId}:${databaseId}.

[Dschoordsch]

+1 Is this so much shorter than

viewerTeamMember {
  isLead
}

?
Let's try to not bloat the interface, just more places where we can introduce bugs.

[Dschoordsch]

+1 The nicer solution would be to have a resolver for the insights type. Define the DB type as source for it and then have a single id field doing this conversion. This way it will work in all occurrences where we would add this field.