Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null not distinct #10067

Merged
merged 1 commit into from
Aug 2, 2024
Merged

fix: null not distinct #10067

merged 1 commit into from
Aug 2, 2024

Conversation

mattkrick
Copy link
Member

@mattkrick mattkrick commented Aug 2, 2024

Description

no dupe global providers here!

Summary by CodeRabbit

  • New Features
    • Introduced a migration that updates the uniqueness constraints in the IntegrationProvider table, allowing NULL values to be treated as non-distinct, enhancing flexibility in data handling.
  • Bug Fixes
    • Improved the rollback functionality to revert changes made by the migration, ensuring database integrity.

Signed-off-by: Matt Krick <[email protected]>
Copy link
Contributor

coderabbitai bot commented Aug 2, 2024

Walkthrough

This migration introduces changes to the IntegrationProvider table in a PostgreSQL database, specifically modifying how uniqueness is enforced with respect to NULL values. The new implementation allows NULL values in the columns orgId, teamId, service, and authStrategy to be treated as non-distinct, thereby enhancing flexibility. The migration includes functions to apply these changes and to revert them when necessary.

Changes

Files Change Summary
packages/server/postgres/migrations/1722632147643_IntegrationProvider-null-not-distinct.ts Introduces functions up and down for modifying unique constraint behaviour, allowing NULLs to be non-distinct.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Database

    Client->>Database: Run migration
    Database-->>Client: Establish connection
    Client->>Database: Execute 'up' function
    Database-->>Client: Drop unique constraint
    Database-->>Client: Add new unique constraint (NULLs non-distinct)
    Client->>Database: Execute 'down' function
    Database-->>Client: Drop new unique constraint
    Database-->>Client: Restore original unique constraint
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the size/s label Aug 2, 2024
@mattkrick mattkrick merged commit e6204a7 into master Aug 2, 2024
8 checks passed
@mattkrick mattkrick deleted the fix/provider-null-not-distinct branch August 2, 2024 21:04
@github-actions github-actions bot mentioned this pull request Aug 2, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant