Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add GH Action, on Snyk PRs commit yarn.lock #9534

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

jordanh
Copy link
Contributor

@jordanh jordanh commented Mar 14, 2024

Description

Had a couple of minutes for a little palette cleanser. Decided to create this action.

If the PR title include [snyk] (case-insensitive), check out the PR branch, run yarn install, and then commit the resulting lock file and push the branch.

Testing scenarios

  • Close a snyk PR and reopen it

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@jordanh
Copy link
Contributor Author

jordanh commented Mar 15, 2024

We're going to merge it 🔒 , and see what happens 😬

@jordanh jordanh force-pushed the chore/add-snyk-yarn-lock-commit-workflow branch from 9c3962f to 1ae3d80 Compare March 15, 2024 00:02
@jordanh jordanh merged commit bd907a9 into master Mar 15, 2024
4 checks passed
@jordanh jordanh deleted the chore/add-snyk-yarn-lock-commit-workflow branch March 15, 2024 00:02
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants