Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor add template mutation to the new sdl pattern #9533

Merged
merged 21 commits into from
Mar 25, 2024
Merged

chore: refactor add template mutation to the new sdl pattern #9533

merged 21 commits into from
Mar 25, 2024

Conversation

nickoferrall
Copy link
Contributor

@nickoferrall nickoferrall commented Mar 14, 2024 •
edited
Loading

This PR refactors the addReflectTemplate and addPokerTemplate to the new SDL pattern.

To test

  • Adding a reflect & poker template still works as expected

@nickoferrall nickoferrall self-assigned this Mar 14, 2024
@github-actions github-actions bot added size/l and removed size/m labels Mar 15, 2024
@nickoferrall nickoferrall marked this pull request as ready for review March 15, 2024 17:53
Dschoordsch
Dschoordsch requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@Dschoordsch Dschoordsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why the subscription for reflection templates was removed.

packages/server/graphql/public/typeDefs/Subscriptions.graphql Show resolved Hide resolved
packages/client/mutations/AddPokerTemplateMutation.ts Show resolved Hide resolved
@nickoferrall
Copy link
Contributor Author

I'll merge this PR once the parent is approved 👍

Base automatically changed from feat/9473/two-custom-template-limit to master March 22, 2024 00:34
@nickoferrall nickoferrall merged commit fe71841 into master Mar 25, 2024
5 checks passed
@nickoferrall nickoferrall deleted the chore/add-template-sdl-refactor branch March 25, 2024 18:34
@parabol-release-bot parabol-release-bot bot mentioned this pull request Mar 25, 2024
Merged
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dschoordsch Dschoordsch Dschoordsch approved these changes

Assignees

@nickoferrall nickoferrall

Labels
size/l
Projects
Product
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickoferrall @Dschoordsch