Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed broken Rally links and fixed Youtube links #9332

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

mwermuth
Copy link
Contributor

@mwermuth mwermuth commented Jan 11, 2024

Description

Fixes #9063

Removed three broken Rally links that I wasn't sure where they linked to (and as we still have quite a few it didn't feel worth it to investigate further). For the other three Youtube Links I edited and replaced the old link

Demo

Opening fixed Rally link

Testing scenarios

[Please list all the testing scenarios a reviewer has to check before approving the PR]

  • Click on the following All Caught Up Links - a Youtube video should show.
    • Don't Stop Believin'
    • On With the Show
    • Right Here, Right Now

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label One Review Required if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@jordanh jordanh force-pushed the fix/9063/fix-broken-rally-links branch from bc1556e to fd0678e Compare March 26, 2024 16:13
@jordanh jordanh merged commit 5e98234 into master Mar 26, 2024
5 checks passed
@jordanh jordanh deleted the fix/9063/fix-broken-rally-links branch March 26, 2024 16:14
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YouTube video link for all caught up message is broken
3 participants