Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor NewMeetingTeamPicker menu to Radix #9274

Closed
1 task
nickoferrall opened this issue Dec 6, 2023 · 1 comment · Fixed by #9679
Closed
1 task

Refactor NewMeetingTeamPicker menu to Radix #9274

nickoferrall opened this issue Dec 6, 2023 · 1 comment · Fixed by #9679
Assignees
@Dschoordsch
Labels
chore

Comments

@nickoferrall
Copy link
Contributor

The NewMeetingTeamPicker currently has a meeting prop called positionOverride, which feels a bit hacky.

We need to update the positionOverride if it's on mobile. Its position can be unreliable and needs a refresh - see Loom: https://www.loom.com/share/26a4e81d4d2041ca8d4eaff014dd8e0d

Hopefully, refactoring this useMenu to the Radix menu can make it more reliable and enable us to remove the positionOverride prop.

AC

  • Refactor NewMeetingTeamPicker useMenu to the Radix Menu component
@nickoferrall nickoferrall mentioned this issue Dec 6, 2023
Merged
1 task
@jordanh jordanh added this to Product Mar 15, 2024
@github-project-automation github-project-automation bot moved this to To triage in Product Mar 15, 2024
@jordanh jordanh moved this from To triage to Ready in Product Mar 15, 2024
@jordanh
Copy link
Contributor

jordanh commented Mar 15, 2024

Going to elevate the priority of this one as this cycle is focusing on getting the AL out to everybody

This was referenced Mar 15, 2024
Closed
Open
@Dschoordsch Dschoordsch self-assigned this Apr 17, 2024
@Dschoordsch Dschoordsch moved this from Ready to In progress in Product Apr 17, 2024
@Dschoordsch Dschoordsch mentioned this issue Apr 29, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in Product Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dschoordsch Dschoordsch

Labels
chore
Projects
Product
Status: Done
🧁Product Squad Self Raise
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: refactor new meeting team dropdown ParabolInc/parabol
4 participants
@jordanh @mwermuth @Dschoordsch @nickoferrall