Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agenda item remove buttons show on hover #225

Closed
ackernaut opened this issue Aug 24, 2016 · 4 comments
Closed

Agenda item remove buttons show on hover #225

ackernaut opened this issue Aug 24, 2016 · 4 comments
Assignees

Comments

@ackernaut
Copy link
Member

UI Enhancement

When I am using the agenda list (on the team dashboard or within the meeting) I need a remove button that only shows on hover so that I can remove items from a clean, less noisy UI design.

Estimated effort: 1 point (see CONTRIBUTING.md)

@mattkrick
Copy link
Member

I'm not sure I agree, since that means mobile users can't delete agenda items...

@ackernaut
Copy link
Member Author

I agree with you…but we are ice-boxing handling mobile/responsive/adaptive at this stage. I would want to handle touch through styles, props and/or different components/layouts.

@jordanh
Copy link
Contributor

jordanh commented Sep 12, 2016

I think @ackernaut's approach is fine for now, since I think the very next thing we do post-Beta is a mobile-first redesign. Let's fight to earn that right.

@mattkrick
Copy link
Member

implemented in latest PR!
FWIW, I still think it's really confusing for those who don't know it exists. When looking at the page, I have no idea how to delete an item. When i hover over a completed item, nothing happens. Only when i highlight a future item does an X pop up. I think hover is good for non-essentials like darkening a button & should be avoided for core functionality, but it's cool if we disagree!

@jordanh jordanh removed the ready label Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants