Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orgAdmins): archived teams should be removed from the OrgTeams view #10142

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Aug 19, 2024

Description

Fixes #10076

Demo

2024-08-19 14 46 35

Testing scenarios

  • Archive team from org admin page
    • Go to http://localhost:3000/me/organizations/xxx/teams as a team/billing lead or org admin
    • Click into a. team
    • Click to top-right drop down menu and select "Delete Team"
    • In the opened-up modal, type the team name and click the red button
    • Observe the page falls back to http://localhost:3000/me/organizations/xxx/teams and the archived team has been removed from the list

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe added Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved and removed Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved labels Aug 19, 2024
@tianrunhe tianrunhe added the Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved label Aug 19, 2024
@tianrunhe tianrunhe merged commit c70b87a into master Aug 22, 2024
8 checks passed
@tianrunhe tianrunhe deleted the 10076-refresh-required-to-see-a-team-has-been-deleted-by-org-admin-from-teams-within-org-settings branch August 22, 2024 14:54
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/xs Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh required to see a team has been deleted by Org Admin from 'Teams' within Org settings
2 participants