Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify find_clang.cr #36

Open
docelic opened this issue May 12, 2020 · 1 comment
Open

Simplify find_clang.cr #36

docelic opened this issue May 12, 2020 · 1 comment

Comments

@docelic
Copy link
Collaborator

docelic commented May 12, 2020

There is a bit of overlap between clang/find_clang.cr and clang/CMakeLists.txt.

find_clang supports finding the clang++ binary, but this is redundant as CMake will figure it out and call find_clang with option --clang PATH.

Also, as @kalinon mentions in #32 , probably more optimizations can be made by directly reading values from one of:

llvm-config
    --cxxflags
    --ldflags
    --libs all
    --includedir

Instead of parsing those values out manually from parts of clang++ output.

@kalinon
Copy link
Contributor

kalinon commented May 12, 2020

llvm-config --binpath as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants