Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reset ASG ID if not found #24

Merged
merged 2 commits into from
Sep 14, 2020
Merged

fix: Reset ASG ID if not found #24

merged 2 commits into from
Sep 14, 2020

Conversation

paperspace-philip
Copy link
Contributor

No description provided.

jaredscheib
jaredscheib previously approved these changes Sep 9, 2020
Copy link
Contributor

@jaredscheib jaredscheib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a convenience during development? seems like ASGs shouldn't be disappearing frequently, especially if terraform is being used to provision in the first place. if folks are going outside of terraform frequently, then why use terraform in the first place?

@paperspace-philip
Copy link
Contributor Author

All terraform resources should be resilient to state synchronization issues. User's should be able to use terraform and a web ui or API

@paperspace-philip paperspace-philip merged commit 1b49848 into master Sep 14, 2020
@paperspace-philip paperspace-philip deleted the asg-reset-id branch September 14, 2020 03:35
@PSBOT
Copy link

PSBOT commented Sep 14, 2020

🎉 This PR is included in version 0.2.13 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@PSBOT PSBOT added the released label Sep 14, 2020
@PSBOT
Copy link

PSBOT commented Mar 31, 2021

🎉 This PR is included in version 0.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants