feat: add storage providers commands #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ani-ps
reviewed
Apr 5, 2024
ani-ps
reviewed
Apr 5, 2024
| }).run(function* ({ ctx }) { | ||
| for (const line of update.help(ctx)) { | ||
| yield line; | ||
| } |
There was a problem hiding this comment.
Does the update only updates s3? or why is this one returning a message and we have update/s3?
There was a problem hiding this comment.
This way if you type pspace storage-provider update it will give a help message indicating that there's an s3 subcommand.
We only want to do s3 for now, adding DO/others is out of scope and will be after the initial release.
There was a problem hiding this comment.
Should we add some description in line 12 about being prompted to select a type.
There was a problem hiding this comment.
It actually does prompt already:
kevin@L21C424TL4 cli % bin/macos-arm/pspace storage-provider update
Update a storage provider.
Usage
pspace storage-provider update [command]
pspace storage-provider update [flags]
Available Commands
help Show help for a update command
s3 Update an S3 storage provider
Global Flags
--api-key string A Paperspace public API Key used for authenticating requests
--api-url string A URL for the Paperspace API.
-h, --help Show help for a command
-j, --json Output JSON
-l, --log-level string Enable debug logging
Use "pspace storage-provider update [command] --help" for more information about a command.
ani-ps
approved these changes
Apr 8, 2024
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.