Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasets): add dataset create/delete/get/list commands #59

Merged
merged 10 commits into from
Apr 5, 2024
Merged

Conversation

ps-kwang
Copy link
Contributor

@ps-kwang ps-kwang commented Apr 4, 2024

No description provided.

@ps-kwang ps-kwang requested a review from brodeyn April 4, 2024 13:13
Copy link
Contributor

@chesterbr chesterbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems we still need to figure out the orderBy thing; happy to re-approve when so.

commands/dataset/list/mod.ts Outdated Show resolved Hide resolved
@ps-kwang ps-kwang requested review from ani-ps and chesterbr April 5, 2024 12:21
Copy link
Contributor

@chesterbr chesterbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome you included the update as well! One last lint issue and should be ready to 🚢 ; preemptive approval here!

api/dataset.ts Outdated Show resolved Hide resolved
Co-authored-by: Carlos Duarte Do Nascimento (Chester) <[email protected]>
@ps-kwang ps-kwang merged commit aff5856 into main Apr 5, 2024
2 checks passed
@ps-kwang ps-kwang deleted the datasets branch April 5, 2024 13:58
Copy link

github-actions bot commented Apr 9, 2024

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants