minor enhancement: make _storedERC721Ids internal
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaavar
changed the title
_storedERC721Ids internal_storedERC721Ids internal
|
@mathdroid could I please get a review on this? |
|
this is a good change, otherwise the contract that extends off this will have to instantiate it again if they want to override methods that use it like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request is for addressing this issue.
The change makes it easier for developers to build features by accessing variable
_storedERC721Idsas part of an inherited contract.Change Summary
The change in this PR switches
_storedERC721Idsaccess modifier fromprivatetointernal.