Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PR ID prefix for azure random names #6

Merged
merged 1 commit into from
Sep 1, 2023
Merged

feat: PR ID prefix for azure random names #6

merged 1 commit into from
Sep 1, 2023

Conversation

FoSix
Copy link
Contributor

@FoSix FoSix commented Aug 30, 2023

Description

Add a possibility to enrich the name_prefix parameter with a PR ID

Motivation and Context

When PR number is passed as PRID env. variable it will become part of the name_prefix. This way it's easier to identify all resources belonging to a particular PR and created during tests. It makes it also possible selectively delete resources when cleaning up after a failed CI.

How Has This Been Tested?

Tested on a copy of Azure repo.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

Copy link
Contributor

@sebastianczech sebastianczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FoSix FoSix merged commit 48cd0df into main Sep 1, 2023
@FoSix FoSix deleted the azure-pr-id branch September 1, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants