refactor!: Namegenerator functions refactor #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
horiagunica
changed the title
horiagunica
changed the title
There was a problem hiding this comment.
Great job, thank you for refactoring code and doing 1 function (instead multiple ones per cloud) 👍
Besides below comments, I have also 1 more question - what is the reason to pass PROJECT_ID via Terratest skeleton , do not change anything in that value and return it in struct TerraformVarsInfo ? Maybe we could directly get project ID in tests in repository terraform-google-vmseries-modules, without passing that value into skeleton and reading it from outputs ?
Co-authored-by: Sebastian Czech <[email protected]>
Co-authored-by: Sebastian Czech <[email protected]>
sebastianczech
approved these changes
Sep 20, 2023
horiagunica
changed the title
|
🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor Name Generator function into a single function. Also introduce obtaining GCP project ID based on repo secrets environment variables.
This PR closes #9 .
Motivation and Context
Code refactoring.
How Has This Been Tested?
Tested using separate test repo : https://github.com/PaloAltoNetworks/test-gcp-ci-workflows/ .
Tested by pointing the GO module to the specific branch .
Types of changes
Checklist