Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

fix(module/autoscale): Null delicensing_cloud_function_config config fixed #223

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

pavelrn
Copy link
Contributor

@pavelrn pavelrn commented Sep 18, 2023

Description

When running examples/autoscaling if delicensing_cloud_function_config = null the example fails to run.
See issue for details.

Motivation and Context

PR fixes issue #222

How Has This Been Tested?

Terraform plan & apply for the autoscale example.

Screenshots (if appropriate)

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@pavelrn pavelrn requested a review from a team as a code owner September 18, 2023 10:32
@pavelrn pavelrn changed the title Null delicensing_cloud_function_config config fixed (fix/nodule_autoscale)Null delicensing_cloud_function_config config fixed Sep 18, 2023
@pavelrn pavelrn changed the title (fix/nodule_autoscale)Null delicensing_cloud_function_config config fixed (fix/module_autoscale)Null delicensing_cloud_function_config config fixed Sep 18, 2023
@pavelrn pavelrn changed the title (fix/module_autoscale)Null delicensing_cloud_function_config config fixed fix(module/autoscale)Null delicensing_cloud_function_config config fixed Sep 18, 2023
@pavelrn pavelrn changed the title fix(module/autoscale)Null delicensing_cloud_function_config config fixed fix(module/autoscale) Null delicensing_cloud_function_config config fixed Sep 18, 2023
@pavelrn pavelrn changed the title fix(module/autoscale) Null delicensing_cloud_function_config config fixed fix(module/autoscale): Null delicensing_cloud_function_config config fixed Sep 18, 2023
@pavelrn pavelrn self-assigned this Sep 18, 2023
@pavelrn pavelrn added bug Something isn't working gcp labels Sep 18, 2023
Copy link
Contributor

@horiagunica horiagunica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@sebastianczech sebastianczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@migara migara merged commit a3bff73 into main Sep 21, 2023
@migara migara deleted the 222-fix-delic-func-null branch September 21, 2023 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working gcp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants