Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

feat: added L3_DEFAULT, backend_services, and connection tracking (fixes #104) #105

Merged
merged 8 commits into from
Jun 16, 2022

Conversation

salsop
Copy link
Contributor

@salsop salsop commented Jun 5, 2022

Description

Added L3_DEFAULT
Added Backend_Service resources to support this.
Added Connection Tracking, as this will be required later for Active/Passive deployments.

Motivation and Context

Without this fix, you have to specify a large number of Forwarding Rules, this makes it simple to follow everything.

How Has This Been Tested?

I've tested this in my own lab environment

Screenshots (if appropriate)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • [x ] I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@salsop salsop requested a review from migara June 10, 2022 15:47
Copy link
Member

@migara migara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @salsop 👏🏽 I have added some suggestions, please accept/reject as needed.

Did you have a chance to check the new inputs/outputs break the existing examples which use this module?

modules/lb_external/main.tf Outdated Show resolved Hide resolved
modules/lb_external/main.tf Outdated Show resolved Hide resolved
modules/lb_external/main.tf Outdated Show resolved Hide resolved
modules/lb_external/outputs.tf Outdated Show resolved Hide resolved
modules/lb_external/main.tf Outdated Show resolved Hide resolved
modules/lb_external/main.tf Outdated Show resolved Hide resolved
@salsop
Copy link
Contributor Author

salsop commented Jun 16, 2022

Great work @salsop 👏🏽 I have added some suggestions, please accept/reject as needed.

Did you have a chance to check the new inputs/outputs break the existing examples which use this module?

@migara I've tested with the hub_spoke_common example and all worked well with the changes, so should be a non-breaking change.

@salsop salsop requested a review from migara June 16, 2022 11:43
@migara migara merged commit 7199510 into PaloAltoNetworks:develop Jun 16, 2022
@github-actions
Copy link

🎉 This PR is included in version 0.2.0 🎉

The release is available on Terraform Registry and GitHub release

Posted by semantic-release bot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants