Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modules/autoscale): google_secret_manager_secret argument deprecation warning #15

Merged
merged 1 commit into from
Mar 8, 2024
Merged

fix(modules/autoscale): google_secret_manager_secret argument deprecation warning #15

merged 1 commit into from
Mar 8, 2024

Conversation

michalbil
Copy link
Contributor

Description

Update google_secret_manager_secret argument to use current spec.

Motivation and Context

Resolves #14

How Has This Been Tested?

Apply vpc_peering_common_with_autoscale example, modified to include delicensing feature.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@michalbil michalbil requested a review from a team as a code owner March 7, 2024 16:13
@michalbil michalbil merged commit 623e153 into main Mar 8, 2024
21 checks passed
@michalbil michalbil deleted the fix-secret-argument-deprecation-warning branch March 8, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelrn pavelrn pavelrn approved these changes

@pimielowski pimielowski pimielowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[modules/asg] Argument Deprecation Warning
3 participants
@michalbil @pimielowski @pavelrn