This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
feat!: introduce basic Terratest based tests, unified Makefile and ChatOPS like workflows #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoSix
force-pushed
the
263-terratest-for-azure
branch
from
August 28, 2023 14:20
429b6c2
to
7db309e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
sebastianczech
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
4 tasks
sebastianczech
pushed a commit
that referenced
this pull request
Oct 18, 2023
…atOPS like workflows (#304)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will introduce:
Makefile
, repository-wide, flexible enough to handle any new Terratest based test.plan/apply
, Terraform based one)Motivation and Context
Makefile
With a single Makefile there will be no copy pasting between modules. The current one is capable of running any test in any module (modules/examples).
TL;DR
To run a test (from the repository's root folder):
Example:
Run
make help
for more details.Terratest based action
This action is simply a GH Actions wrapper around the new Makefile. It will be fully usable by the reusable workflows introduced in this PR.
ChatOPS introduction
The ChatOPS-like workflows provide a way of running on demand, Terratest based tests. They can become handy in situations where a particular test is not run in PR CI workflow (Apply/Idempotence), or the CI workflow is not triggered (PRs created by other workflows, like pre-commit dependencies update).
Currently there are 4 supported commands:
sca
- runs pre-commit with all testsplan
- runs plan actionapply
- runs apply actionidempotence
- runs idempotence test (apply following a plan)The 1st one takes no parameters. The remaining can take two:
paths
- space separated list of module paths to testtf_version
- (optional) space separated list of Terraform versions to use to run the test, when skipped, the latest Terraform version will be used.Example:
/validate paths="examples/common_vmseries modules/vnet"
load_balancer
moduleThere is a small change in this module to add flexibility to how we specify the NSG. Next to the old approach one can also use key values from the VNET definition to reference an NSG that will be created by the Terraform code.
How Has This Been Tested?
Some of the tests can be seen in the PR CI triggered by this workflow.
The ChatOPS tests can be run/tested on the Azure test repo.
Screenshots (if appropriate)
Types of changes
Checklist