Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

feat: checkov output pre commit #258

Merged
merged 32 commits into from
Jun 22, 2023
Merged

feat: checkov output pre commit #258

merged 32 commits into from
Jun 22, 2023

Conversation

horiagunica
Copy link
Contributor

@horiagunica horiagunica commented May 5, 2023 •
edited
Loading

Description

Implement Checkov fixes and remove global soft-fail.

This PR Closes #200 .

Motivation and Context

Code security improvements.

How Has This Been Tested?

Re-deploy all existing examples.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@horiagunica horiagunica requested a review from a team as a code owner May 5, 2023 08:53
@horiagunica horiagunica changed the title 200 checkov output pre commit feat: checkov output pre commit May 5, 2023
FoSix
FoSix suggested changes May 5, 2023
View reviewed changes
Copy link
Contributor

@FoSix FoSix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻
some minor changes required

examples/common_vmseries/main.tf Outdated Show resolved Hide resolved
examples/dedicated_vmseries_and_autoscale/main.tf Show resolved Hide resolved
modules/bootstrap/variables.tf Outdated Show resolved Hide resolved
modules/bootstrap/variables.tf Outdated Show resolved Hide resolved
modules/bootstrap/variables.tf Outdated Show resolved Hide resolved
modules/bootstrap/variables.tf Outdated Show resolved Hide resolved
modules/virtual_machine/main.tf Show resolved Hide resolved
modules/vmss/main.tf Outdated Show resolved Hide resolved
@horiagunica horiagunica force-pushed the 200-checkov-output-pre-commit branch from b669bb4 to 57a38ff Compare May 9, 2023 14:22
@horiagunica horiagunica requested a review from FoSix May 10, 2023 08:41
FoSix
FoSix suggested changes May 11, 2023
View reviewed changes
examples/common_vmseries/main.tf Show resolved Hide resolved
examples/common_vmseries/variables.tf Outdated Show resolved Hide resolved
examples/common_vmseries/variables.tf Outdated Show resolved Hide resolved
examples/dedicated_vmseries/example.tfvars Outdated Show resolved Hide resolved
examples/common_vmseries/main.tf Outdated Show resolved Hide resolved
@horiagunica horiagunica requested a review from FoSix May 11, 2023 11:38
FoSix
FoSix approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@FoSix FoSix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@FoSix FoSix merged commit 5bcc69f into main Jun 22, 2023
@FoSix FoSix deleted the 200-checkov-output-pre-commit branch June 22, 2023 05:17
@welcome-to-palo-alto-networks
Copy link

🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️

sebastianczech pushed a commit that referenced this pull request Oct 18, 2023
@horiagunica
feat: checkov output pre commit (#258)
31881d2 
Introducing minor changes to modules to enhance security - no changes to default behaviour though.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FoSix FoSix FoSix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve checkov output in pre-commit.
2 participants
@horiagunica @FoSix