Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

feat(module/vmss): allow VMSS reference backend address pools of application gateways #249

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

sebastianczech
Copy link
Contributor

Description

PR delivers changes in vmss module in order to allow scale set to reference backend address pools of multiple application gateways.

Motivation and Context

Support for VMSS behind application gateway was required in customer project, so in order to fulfil in future similar requests, PR was prepared.

How Has This Been Tested?

Changes were tested in the lab before delivering it in the project to customer.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech sebastianczech requested a review from a team as a code owner April 3, 2023 06:50
Copy link
Contributor

@pimielowski pimielowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@FoSix FoSix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 - just some small comments

modules/vmss/variables.tf Show resolved Hide resolved
modules/vmss/variables.tf Outdated Show resolved Hide resolved
modules/vmss/variables.tf Show resolved Hide resolved
@FoSix FoSix merged commit 82e7336 into main Apr 5, 2023
@FoSix FoSix deleted the vmss_appgw branch April 5, 2023 08:17
sebastianczech added a commit that referenced this pull request Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants