Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

fix(example/transit_vnet_common): add code flexibility #229

Merged
merged 9 commits into from
Mar 15, 2023

Conversation

FoSix
Copy link
Contributor

@FoSix FoSix commented Jan 20, 2023

Description

Add code flexibility.

Motivation and Context

Move away from hardcoded configuration in main.tf. This way this example can be used to deploy a particular code (or reference architecture) in different variations.

How Has This Been Tested?

Deployed the example successfully.

Screenshots (if appropriate)

Types of changes

  • refactor

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@FoSix FoSix requested a review from a team as a code owner January 20, 2023 16:02
@FoSix FoSix linked an issue Jan 20, 2023 that may be closed by this pull request
@FoSix FoSix marked this pull request as draft January 20, 2023 16:03
@FoSix FoSix self-assigned this Jan 20, 2023
@FoSix FoSix changed the title refactor(example/ransit_vnet_common): add code flexibility refactor(example/transit_vnet_common): add code flexibility Feb 2, 2023
@FoSix FoSix marked this pull request as ready for review February 16, 2023 11:53
Copy link
Member

@migara migara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👏🏽

examples/transit_vnet_common/example.tfvars Outdated Show resolved Hide resolved
examples/transit_vnet_common/versions.tf Show resolved Hide resolved
examples/transit_vnet_common/example.tfvars Outdated Show resolved Hide resolved
examples/transit_vnet_common/example.tfvars Outdated Show resolved Hide resolved
examples/transit_vnet_common/example.tfvars Outdated Show resolved Hide resolved
@FoSix FoSix changed the title refactor(example/transit_vnet_common): add code flexibility fix(example/transit_vnet_common): add code flexibility Feb 27, 2023
@FoSix FoSix force-pushed the 228-examples-refactor-transit_vnet_common branch from f98be39 to 6067ff2 Compare March 1, 2023 14:26
@FoSix FoSix force-pushed the 228-examples-refactor-transit_vnet_common branch from 6067ff2 to 861f400 Compare March 1, 2023 14:28
@migara migara merged commit ce745e4 into main Mar 15, 2023
@migara migara deleted the 228-examples-refactor-transit_vnet_common branch March 15, 2023 11:38
sebastianczech pushed a commit that referenced this pull request Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

examples refactor: transit_vnet_common
2 participants