This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
fix(example/transit_vnet_common): add code flexibility #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoSix
changed the title
refactor(example/ransit_vnet_common): add code flexibility
refactor(example/transit_vnet_common): add code flexibility
Feb 2, 2023
migara
approved these changes
Feb 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👏🏽
FoSix
changed the title
refactor(example/transit_vnet_common): add code flexibility
fix(example/transit_vnet_common): add code flexibility
Feb 27, 2023
FoSix
force-pushed
the
228-examples-refactor-transit_vnet_common
branch
from
March 1, 2023 14:26
f98be39
to
6067ff2
Compare
FoSix
force-pushed
the
228-examples-refactor-transit_vnet_common
branch
from
March 1, 2023 14:28
6067ff2
to
861f400
Compare
sebastianczech
pushed a commit
that referenced
this pull request
Oct 18, 2023
Co-authored-by: Migara Ekanayake <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add code flexibility.
Motivation and Context
Move away from hardcoded configuration in
main.tf
. This way this example can be used to deploy a particular code (or reference architecture) in different variations.How Has This Been Tested?
Deployed the example successfully.
Screenshots (if appropriate)
Types of changes
Checklist