Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

fix: extend bootstrap options validation #197

Merged

Conversation

FoSix
Copy link
Contributor

@FoSix FoSix commented Sep 29, 2022

Description

Extend a list of possible boostrap_options to cover Azure specifics.

Motivation and Context

Fixes #193 reported by @pmusolino-rms.

How Has This Been Tested?

Examples using storage account for bootstrapping were deployed.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@FoSix FoSix requested a review from a team as a code owner September 29, 2022 13:22
@FoSix FoSix linked an issue Sep 29, 2022 that may be closed by this pull request
@FoSix FoSix self-assigned this Sep 29, 2022
@FoSix FoSix added bug Something isn't working azure labels Sep 29, 2022
Copy link
Member

@migara migara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌🏽

@FoSix FoSix merged commit 48ef618 into develop Oct 5, 2022
@FoSix FoSix deleted the 193-transit_vnet_common-example-build-fails-on-terraform-apply branch October 5, 2022 06:38
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

🎉 This PR is included in version 0.5.0 🎉

The release is available on Terraform Registry and GitHub release

Posted by semantic-release bot

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
azure bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transit_vnet_common example build fails on terraform apply
3 participants