This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
fix!: add app insights worker mode (#146) #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblaszc
force-pushed
the
issue146_app-insights_workspace
branch
2 times, most recently
from
6c18442 to
72eb2f7
Compare
jblaszc
force-pushed
the
issue146_app-insights_workspace
branch
2 times, most recently
from
f512c6c to
fe983f6
Compare
jblaszc
changed the title
* fix(modules/vmseries): add 'azurerm_log_analytics_workspace' resource
update 'azurerm_application_insights' so it can use workspaces
add 'app_insights_settings' map variable that holds all app_insights related parameters
remove 'name_application_insights' variable, moved to 'app_insights_settings' var
remove 'metrics_retention_in_days' variable, moved to 'app_insights_settings' var
* fix(modules/vmss): add 'azurerm_log_analytics_workspace' resource
update 'autoscale_metrics' defaults values to empty map
update 'azurerm_application_insights' so it can use workspaces
add 'app_insights_settings' map variable that holds all app_insights related parameters
* fix(examples/vmss): update example, so the new 'app_insights_settings' variable is used
* docs(module/vmseries): add 'app_insights_settings' variable description
* docs(module/vmss): add 'app_insights_settings' variable description
jblaszc
force-pushed
the
issue146_app-insights_workspace
branch
from
3bf565f to
d9df242
Compare
FoSix
changed the title
FoSix
changed the title
michalbil
approved these changes
Oct 3, 2022
|
🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️ |
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on Terraform Registry and GitHub release
|
sebastianczech
pushed a commit
that referenced
this pull request
Oct 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for Application Insights workspace-based mode and setting it as the default.
BREAKING CHANGE: default behaviour as well as variables used to define Application Insights of the
vmseriesandvmssmodule will change.Motivation and Context
For the moment the vmseries module support creation of classic AI only. There are regions where only workspace mode for AI is supported. This causes the module to crash during AI provisioning.
Azure recommends to use a workspace-based Application Insights mode now. All new Azure regions introduced after Feb 2021 do not support creating classic AI resources. For the older regions, support for classic AI mode will end on Feb 29th 2024.
This fix sets the workspace-based as the default mode if Application Insights is required. In case the Classic mode is needed, it can be forced by setting
app_insights_settings.workspace_modevariable tofalse.This PR:
How Has This Been Tested?
A vmseries (standalone and scale set) examples were built with AI mode set to workspace-based and Classic.
Screenshots (if appropriate)
Types of changes
Checklist