Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

fix: missing variable for special character #141

Conversation

pimielowski
Copy link
Contributor

Description

Add missing variable required for overrides special character list in password generator.

Motivation and Context

It fix special character list used for password creation.

How Has This Been Tested?

I take portions of code used for password creation with missing variable and run a couple of times and see in output if there is non specified character from the special character list.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@welcome-to-palo-alto-networks
Copy link

🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌

@pimielowski pimielowski changed the title Fix missing variable for special character Fix: missing variable for special character Feb 9, 2022
@pimielowski pimielowski changed the title Fix: missing variable for special character fix: missing variable for special character Feb 9, 2022
Copy link
Member

@migara migara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@migara migara merged commit 4b60487 into PaloAltoNetworks:develop Feb 9, 2022
@welcome-to-palo-alto-networks
Copy link

🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️

@pimielowski pimielowski deleted the fix-missing-variable-for-special-character branch February 9, 2022 10:46
migara pushed a commit that referenced this pull request Jul 5, 2022
The `random_password` will now exclude `_%@` characters when generating passwords

Co-authored-by: Pawel Imielowski <[email protected]>
Co-authored-by: Pawel Imielowski <[email protected]>
migara added a commit that referenced this pull request Jul 5, 2022
@github-actions
Copy link
Contributor

🎉 This PR is included in version 0.4.0 🎉

The release is available on Terraform Registry and GitHub release

Posted by semantic-release bot

sebastianczech pushed a commit that referenced this pull request Oct 18, 2023
The `random_password` will now exclude `_%@` characters when generating passwords

Co-authored-by: Pawel Imielowski <[email protected]>
Co-authored-by: Pawel Imielowski <[email protected]>
sebastianczech pushed a commit that referenced this pull request Oct 18, 2023
The `random_password` will now exclude `_%@` characters when generating passwords

Co-authored-by: Pawel Imielowski <[email protected]>
Co-authored-by: Pawel Imielowski <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants