This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
fix: missing variable for special character #141
Merged
migara
merged 3 commits into
PaloAltoNetworks:develop
from
pimielowski:fix-missing-variable-for-special-character
Feb 9, 2022
Merged
fix: missing variable for special character #141
migara
merged 3 commits into
PaloAltoNetworks:develop
from
pimielowski:fix-missing-variable-for-special-character
Feb 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-character' into fix-missing-variable-for-special-character
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
pimielowski
changed the title
Fix missing variable for special character
Fix: missing variable for special character
Feb 9, 2022
pimielowski
changed the title
Fix: missing variable for special character
fix: missing variable for special character
Feb 9, 2022
migara
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️ |
migara
pushed a commit
that referenced
this pull request
Jul 5, 2022
The `random_password` will now exclude `_%@` characters when generating passwords Co-authored-by: Pawel Imielowski <[email protected]> Co-authored-by: Pawel Imielowski <[email protected]>
🎉 This PR is included in version 0.4.0 🎉 The release is available on Terraform Registry and GitHub release
|
sebastianczech
pushed a commit
that referenced
this pull request
Oct 18, 2023
The `random_password` will now exclude `_%@` characters when generating passwords Co-authored-by: Pawel Imielowski <[email protected]> Co-authored-by: Pawel Imielowski <[email protected]>
sebastianczech
pushed a commit
that referenced
this pull request
Oct 18, 2023
The `random_password` will now exclude `_%@` characters when generating passwords Co-authored-by: Pawel Imielowski <[email protected]> Co-authored-by: Pawel Imielowski <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing variable required for overrides special character list in password generator.
Motivation and Context
It fix special character list used for password creation.
How Has This Been Tested?
I take portions of code used for password creation with missing variable and run a couple of times and see in output if there is non specified character from the special character list.
Types of changes
Checklist