-
Notifications
You must be signed in to change notification settings - Fork 48
feat(example/vmseries_combined): Refactored example for vmseries_combined #305
Conversation
…oNetworks/terraform-aws-vmseries-modules into update-gwlb-tgw-combined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Closes #298 combined_vmseries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM , but I have a question @mariuszgebala - I know , that in the scope of #298 it was renaming the example and improving README, but what do you think about changing approach in the code to make resource dynamically, based on values in tfvars ? We don't need to do it in this PR - maybe let's create new issue and improve that example in new PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariuszgebala can you please change the LB to ALB as we discussed before we merge this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change name of the PR in order to follow conventional commits ? Besides that it looks ok 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 0.4.2 🎉 The release is available on Terraform Registry and GitHub release
|
Description
Improve the tgw_inbound_combined_with_gwlb example
Motivation and Context
The need to change the name and add a more detailed description of the example
Types of changes
Checklist