This repository has been archived by the owner on Feb 14, 2024. It is now read-only.
fix(module/subnet_set): Added VPC selector to match existing subnets in VPC #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
mariuszgebala
changed the title
migara
approved these changes
Apr 5, 2023
|
🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️ |
|
🎉 This PR is included in version 0.4.2 🎉 The release is available on Terraform Registry and GitHub release
|
mariuszgebala
added a commit
that referenced
this pull request
Jul 5, 2023
…in VPC (#292) * Added VPC selector to match existing subnets in VPC * Improved terraform format --------- Co-authored-by: Mariusz Gebala <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a VPC selector to the subnet_set module to avoid problems with identical names of subnets belonging to different VPCs.
Motivation and Context
If there are multiple subnets in the region that match the selected name, we will get the multiple EC2 subnets matched error:
use additional restrictions to reduce the matches to a single EC2 subnet.How Has This Been Tested?
The check was based on a region where there were about a dozen subnets with the same name. After adding the
vpc_idparameter, the expected subnet ID was obtained.Types of changes
Checklist