Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] ASG Delicense still requires manual commit in panorama #4

Closed
jschelfh-be opened this issue Nov 14, 2023 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@jschelfh-be
Copy link

Describe the bug

Using ASG automatic de-license option from panorama is working nicely when scaling-in. However it still requires a manual commit in panorama. We have pipelines to push rules to panorama -> firewalls, but the de-license caused the pipeline to fail on the commitAll to the FWs.

Is it possible to include the commit as well ? (the scope of the commit can be limited to the user that is used to connect to panorama specified in the SSM Parameter: /paloalto/vmseries-asg/delicense)

Module Version

1.0.9

Terraform version

1.6.2

Expected behavior

complete automation of delicensing

Current behavior

requires manual commit

Anything else to add?

No response

@pimielowski pimielowski self-assigned this Nov 14, 2023
@migara
Copy link
Member

migara commented Jan 11, 2024

After issuing the delicensing request via the plugin, maybe we can query the Panorama device list to verify the removal of the device serial number from Panorama before proceeding with the commit operation.

@migara migara transferred this issue from PaloAltoNetworks/terraform-aws-vmseries-modules Jan 11, 2024
@migara migara added the enhancement New feature or request label Jan 11, 2024
@migara
Copy link
Member

migara commented Mar 28, 2024

@seanyoungberg any thoughts on this? Is this something we should take care of?

@migara
Copy link
Member

migara commented Jun 27, 2024

The recommendation is to handle this behaviour outside of these modules (i.e. a different step/stage of the CI/CD pipeline)

Closing this for the time being

@migara migara closed this as completed Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants