Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PANGO Module type PanoramaCommitAll []string support for Name type struct #108

Open
kagaho opened this issue Aug 1, 2023 · 3 comments
Open

Comments

@kagaho
Copy link

kagaho commented Aug 1, 2023

Is your feature request related to a problem?

-- Currently on type PanoramaCommitAll struct type "Name" allows only string (not an Array - "[]string" ). This limitation together with the behavior changes in 10.2 - PAN-OS 10.2 Default Behavior: Shared Configuration Objects for Multi-vsys Firewall Managed by Panorama, became not doable to use PANGO module for the multi-vsys with multi DG envs.

Describe the solution you'd like

Because of the multi vsys (multiple Device Groups on Name type), there are multiple scenarios where on the Commitall on Panorama we declare multiple DGs, as below:

func main() {
commitAll := PanoramaCommitAll{
Type: "exampleType",
Names: []string{"DG1", "DG2", "DG3"}, <<<<<<<<<<<<<<<<<<<<
Description: "example description",
IncludeTemplate: true,
ForceTemplateValues: false,
Devices: []string{"device1", "device2", "device3"},
}

// Accessing individual elements of the array
fmt.Println(commitAll.Names[0]) // Output: "DG1"
fmt.Println(commitAll.Names[1]) // Output: "DG2"

}

Describe alternatives you've considered

NA - at the moment, due to changes in 10.2, commitall for shared object CRUD events is quite limited. Prior PANOS 10.2, all shared objects are created a copy within each vsys, whereas in 10.2 the object remains in a common location, utilised by all vsys'

@welcome-to-palo-alto-networks
Copy link

🎉 Thanks for opening your first issue here! Welcome to the community!

@kagaho
Copy link
Author

kagaho commented Aug 3, 2023

hi, just adding to the previous update, we do need the CommitAll with the enhanced Names: []string to be done in a single job task (and not 1 job per DG).

@SkylerSalvato
Copy link

We would also like to see this feature added! Would it be possible to expand the criteria to include Template Stacks as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants