Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown XML also driving existance of subconfig #68

Open
Tracked by #66
migara opened this issue Apr 19, 2024 · 2 comments
Open
Tracked by #66

Unknown XML also driving existance of subconfig #68

migara opened this issue Apr 19, 2024 · 2 comments

Comments

@migara
Copy link
Member

migara commented Apr 19, 2024

No description provided.

@migara migara mentioned this issue Apr 19, 2024
21 tasks
@sebastianczech
Copy link
Contributor

Currently for every struct for XML we have unknown XML defined as:

Misc []generic.Xml `xml:",any"`` 

For some of the normalized specs we have XPath with multiple strings e.g. for disable-server-response-inspection:

disable_server_response_inspection:
description: 'Disable Server Response Inspection'
type: bool
profiles:
- xpath: [ "option", "disable-server-response-inspection" ]

As a results we are not defining 2 structs, only 1 struct entryXml with XML tag:

DisableServerResponseInspection *string                `xml:"option>disable-server-response-inspection,omitempty"`

So there is no way to define unknown XML under option.

@kklimonda-cl
Copy link
Contributor

The new WIP codegen and XML marshaller/unmarshaller can be improved to handle those edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants