Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gathered_filter): Update logic to cover cases of None #488

Merged
merged 2 commits into from
Sep 8, 2023
Merged

fix(gathered_filter): Update logic to cover cases of None #488

merged 2 commits into from
Sep 8, 2023

Conversation

jamesholland-uk
Copy link
Member

@jamesholland-uk jamesholland-uk commented Sep 8, 2023 •
edited
Loading

Description

Update the logic within gathered_filter for cases where a gathered parameter evaluates to None

Motivation and Context

Fixes #474

How Has This Been Tested?

Tested locally

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

shinmog
shinmog approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamesholland-uk jamesholland-uk mentioned this pull request Sep 8, 2023
Closed
4 tasks
shinmog
shinmog approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jamesholland-uk jamesholland-uk merged commit d2372c5 into develop Sep 8, 2023
@jamesholland-uk jamesholland-uk deleted the update_gatheredfilter_logic branch September 8, 2023 09:09
github-actions bot pushed a commit that referenced this pull request Sep 8, 2023
@semantic-release-bot
chore(release): 2.17.5
2b22d68 
### [2.17.5](v2.17.4...v2.17.5) (2023-09-08)

### Bug Fixes

* **gathered_filter:** Update logic to cover cases of None ([#488](#488)) ([d2372c5](d2372c5))
* **panos_device_group:** Do not move a Device Group if state is set to gathered ([#484](#484)) ([93d61a7](93d61a7))
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

🎉 This PR is included in version 2.17.5 🎉

The release is available on Ansible Galaxy and GitHub release

Posted by semantic-release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinmog shinmog shinmog approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panos_nat_rule2 - failure to gather policies when address field contains null values
2 participants
@jamesholland-uk @shinmog