Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI 3.1 support? #410

Closed
IanVS opened this issue Feb 8, 2023 · 16 comments
Closed

OpenAPI 3.1 support? #410

IanVS opened this issue Feb 8, 2023 · 16 comments
Assignees
Labels
enhancement New feature or request

Comments

@IanVS
Copy link
Contributor

IanVS commented Feb 8, 2023

Is your feature request related to a problem?

I was trying to use open api 3.1.0 syntax, but it seems to be causing problems, so maybe it's not supported?

Describe the solution you'd like

Support 3.1.0

Additional context

Is it already supported and I'm just using it wrong? I do see Compatible: Works with Swagger 2.0 and OpenAPI 3.x. in the website, but when I tried to use type: [string, 'null'], the resulting span was just stringnull smashed together like that, whereas nullable: true added a nice nullable tag.

@IanVS IanVS added the enhancement New feature or request label Feb 8, 2023
@sserrata
Copy link
Member

sserrata commented Feb 8, 2023

Hi @IanVS, OpenAPI 3.1 definitely isn't supported, yet. FWIW, there are tools that will down convert to from 3.1 to 3.0 but there could be loss of features in the process. That said, our plugin does attempt to resolve all JSON schema $ref pointers, regardless of whether or not they follow the OpenAPI spec.

@IanVS
Copy link
Contributor Author

IanVS commented Feb 8, 2023

Thanks for confirming. What would you think about making that clearer in the README? Maybe just change 3.x to 3.0?

@stefan-schweiger
Copy link

3.1 would be really appreciated because you can now have a separate top level element for describing WebHooks

@sserrata
Copy link
Member

What would you think about making that clearer in the README? Maybe just change 3.x to 3.0?

I agree, that could definitely help make it clearer.

Hi @stefan-schweiger, support for 3.1 is on the roadmap. We're hoping to have it ready for our v2.0.0 release in the next 2-3 months.

@jasikpark
Copy link

looks like this'll be a post-2.0 update? I can imagine it's some work to support multiple OpenAPI versions.

@sserrata
Copy link
Member

Hi @jasikpark, it really depends. We use external libraries for parsing so it would really come down to:

  • How well those libraries support OpenAPI 3.1
  • Which unique OpenAPI 3.1 features we decide to support and how compatible those features are with existing UI

@jasikpark
Copy link

ok! thx for breaking that down - maybe this issue can contain the status of those deps

@IanVS
Copy link
Contributor Author

IanVS commented Mar 19, 2024

Hi @sserrata, have you given any more thought to openapi 3.1 support? In specific, I'm wishing we had the ability to describe the shape of dynamic keys on objects: OAI/OpenAPI-Specification#1505.

@sserrata
Copy link
Member

sserrata commented Mar 19, 2024

Hi @IanVS, I checked and there is a more recent release of @redocly/openapi-core that we can upgrade to. I tested a few OpenAPI 3.1 specs with our plugin and it appears to offer some support, although I can't guarantee 100% support/coverage of all 3.1 features.

@sserrata sserrata self-assigned this Mar 27, 2024
@sserrata
Copy link
Member

Hi @IanVS, I was wondering if you've had a chance to test the new @redocly/openapi-core parser?

@IanVS
Copy link
Contributor Author

IanVS commented Mar 27, 2024

Not yet, though I hope to before too long. I'm a bit behind on upgrades and it's going to take a lot of reworking of our custom CSS to update to the latest plugin versions. Was kind of holding off until there was word that docusaurus 3 is fully supported, which would give us even more reason to upgrade.

@sserrata
Copy link
Member

The new parser is also available for 2.1.3 (introduced in 2.1.1).

@IanVS
Copy link
Contributor Author

IanVS commented Mar 27, 2024

I'm still on 2.0.0-beta.2 🙈

@sserrata
Copy link
Member

Closing as limited support for OpenAPI 3.1 is already available

@IanVS
Copy link
Contributor Author

IanVS commented Jul 15, 2024

Hi @sserrata I finally updated to 3.0 of the plugin, and tried using openapi 3.1, but the issue remains that I described at the top of this issue, that using [string, 'null'] results in stringnull instead of a nullable tag. Would you like a separate issue for that?

@jasikpark
Copy link

Added an issue for that specific bug: #950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants