Code Coverage : Tests for groups.js Fix #585 #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have also added a typo fix for |
|
@palisadoes the code is ready to be reviewed |
palisadoes
approved these changes
Sep 19, 2022
DMills27
pushed a commit
that referenced
this pull request
Nov 9, 2022
* Removed package easygraphql-tester (#747) Removed the package named easygraphql-tester because it was not being used anywhere in the app and had a security vulnerability. * Revert "Removed package easygraphql-tester (#747)" (#753) This reverts commit 61818a1. * Bump moment-timezone from 0.5.34 to 0.5.37 (#757) Bumps [moment-timezone](https://github.com/moment/moment-timezone) from 0.5.34 to 0.5.37. - [Release notes](https://github.com/moment/moment-timezone/releases) - [Changelog](https://github.com/moment/moment-timezone/blob/develop/changelog.md) - [Commits](moment/moment-timezone@0.5.34...0.5.37) --- updated-dependencies: - dependency-name: moment-timezone dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Doubled the number of retries The tests have been failing due to timeouts. * add mongodb credentials in github actions yml file * update github actions mongodb parameters * update variable names in github actions * update github actions push file * revert github actions push file * add start period for health check in github actions * add extra health check parameters for mongo * adjust mongo image version * explicitly add mongo version to image for github actions * Removed package easygraphql-tester (#754) * Code Coverage : Tests for groups.js Fix #585 (#769) * Create groups.spec.js * Update groups.spec.js * Update getPlugins.spec.js * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Bump jose from 2.0.5 to 2.0.6 (#770) Bumps [jose](https://github.com/panva/jose) from 2.0.5 to 2.0.6. - [Release notes](https://github.com/panva/jose/releases) - [Changelog](https://github.com/panva/jose/blob/v2.0.6/CHANGELOG.md) - [Commits](panva/jose@v2.0.5...v2.0.6) --- updated-dependencies: - dependency-name: jose dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump file-type and image-hash (#752) Bumps [file-type](https://github.com/sindresorhus/file-type) and [image-hash](https://github.com/danm/image-hash). These dependencies needed to be updated together. Updates `file-type` from 14.7.1 to 16.5.4 - [Release notes](https://github.com/sindresorhus/file-type/releases) - [Commits](sindresorhus/file-type@v14.7.1...v16.5.4) Updates `image-hash` from 4.0.1 to 5.3.1 - [Release notes](https://github.com/danm/image-hash/releases) - [Commits](https://github.com/danm/image-hash/commits) --- updated-dependencies: - dependency-name: file-type dependency-type: indirect - dependency-name: image-hash dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump got and nodemon (#771) Bumps [got](https://github.com/sindresorhus/got) and [nodemon](https://github.com/remy/nodemon). These dependencies needed to be updated together. Removes `got` Updates `nodemon` from 2.0.15 to 2.0.20 - [Release notes](https://github.com/remy/nodemon/releases) - [Commits](remy/nodemon@v2.0.15...v2.0.20) --- updated-dependencies: - dependency-name: got dependency-type: indirect - dependency-name: nodemon dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump vm2 from 3.9.9 to 3.9.11 (#772) Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.9 to 3.9.11. - [Release notes](https://github.com/patriksimek/vm2/releases) - [Changelog](https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md) - [Commits](patriksimek/vm2@3.9.9...3.9.11) --- updated-dependencies: - dependency-name: vm2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Feature Request : Performing Donations ( Ability to store donation transaction in Talwa-api ) (#756) * Test : lib/resolvers/group_chat_query/groupChatMessages.js * Add Test : Added Valid JSON Check * Create README.md * Create README.md * Update is-auth.js * AddedDocs Docs from withfilter pending * Update index.js * completed * sample * update/index.js * update/index.js * update/is-auth.js * Update/readme.md * update/image-readme * Add/query-schema * Update/Plugin-graphQL-schema * Add/Plugin-MongoDB-Model * Add/createPlugin-and-refractoring * Add/getPlugins * Add/Mutation/UpdatePluginStatus * Add/Mutation/updateTempPluginInstalledOrgs * Add/Mutation/Schema * Add/import/mutations * Add/plugins * Fix/path-err * Fix/Erros * update/lockfile * Add/plugin-model * Update is-auth.js * Removed extra queries * Documentation added for plugin queries and models * Fix/`delelte cr in prettier/prettier` * updated : mutation * Add/test `getPlugins` * Fix/`lint error` * test `updatePluginInstalledOrgs` * Test/ `updateInstallStatus` * Fix/Erros-1 * Fix/Erros-2 * Fix/Erros-3 * Test/`Queries.js` * Test/`Mutation.js` * remove extra `console.log` * Delete admin-plugin-query.js * Delete super-admin-plugin-query.js * Fix/Package-lock * Create cancel_membership_request.spec.js * Update cancel_membership_request.js * Update cancel_membership_request.spec.js * Update cancel_membership_request.js * `Typo` * Add : Donation Model * Add : getDonations Query * Add : Schema for Donation * Add : Schema for getDonations query * Add : getDonationById Query * Add : Schema for getDonationById * Fix : `Donation Model` * Add : createDonation Mutation * Add : createDonation Schema * Updated Donation Model * Add : `createDonation` GraphQL Mutation * Fix : `getDonationById` Query * Add : `getDonationByOrgId` Query * Update : Scehma Updated due to change in `Donation` Model * Update : `Donation` Schema in .graphql * Add : `getDonationById` and `getDonationByOrgId` in gql schema * Add : gql Schema for `DeletePayload` * Add : `deleteDonationById` Mutation * Chores : Formatting files * Fix : Lint errors * Test for send_membership_request.js (#763) * test for reject_membership_request.js * send_membership_request.spec.js initialized * test for send_membership_request.js * fixes in test for send membership request * minor fixes in send_membership_request.spec.js * 100% test coverage Co-authored-by: Nishant <[email protected]> * Talawa api multitenancy (#776) * Initial setup (#726) * Initial setup * simplified creation * added readme.md file * added connection manager and id helper functions * Error handling & security updates (#744) * [Feature Request] New Features for Talawa-admin added (#725) * check authentication feature added for talawa admin * tests for check authentication added * minor fixes * typo fixes * minor fixes * npm err fixes * google recaptcha configured * new dependency added * mailer, forgotPassword endpoint and otp endpoint is configured * graphql endpoints updated * constants updated * Documentation updated * tests for changes added * hard coded value error fixes * lint fixes * lint fixes * failed test cases fixes * Failed tests fixes * minor fixes * marked-teminal dependency updated * Tests fixes * tests updated * tests fixes * tests updated * new resolvers added and schema updated * graphql mutations updated * tests updated for changes * tests updated * tests updated * tests updated * minor fixes * [Feature Request] : Plugin Architecture for Server (#730) * Test : lib/resolvers/group_chat_query/groupChatMessages.js * Add Test : Added Valid JSON Check * Create README.md * Create README.md * Update is-auth.js * AddedDocs Docs from withfilter pending * Update index.js * completed * sample * update/index.js * update/index.js * update/is-auth.js * Update/readme.md * update/image-readme * Add/query-schema * Update/Plugin-graphQL-schema * Add/Plugin-MongoDB-Model * Add/createPlugin-and-refractoring * Add/getPlugins * Add/Mutation/UpdatePluginStatus * Add/Mutation/updateTempPluginInstalledOrgs * Add/Mutation/Schema * Add/import/mutations * Add/plugins * Fix/path-err * Fix/Erros * update/lockfile * Add/plugin-model * Update is-auth.js * Removed extra queries * Documentation added for plugin queries and models * Fix/`delelte cr in prettier/prettier` * updated : mutation * Add/test `getPlugins` * Fix/`lint error` * test `updatePluginInstalledOrgs` * Test/ `updateInstallStatus` * Fix/Erros-1 * Fix/Erros-2 * Fix/Erros-3 * Test/`Queries.js` * Test/`Mutation.js` * remove extra `console.log` * Delete admin-plugin-query.js * Delete super-admin-plugin-query.js * Fix/Package-lock * added delimiter to helper functions * error handling for connection manager * added readme.md for connection manager * error handling for Database module Co-authored-by: Asmit Kumar Sirohi <[email protected]> Co-authored-by: Siddhesh Bhupendra Kuakde <[email protected]> * Create new tenant on createOrganization * Custom schema functionality * Added the context function * modify createPost resolver * fix createPost, createOrganization resolvers * Initial setup (#726) * Initial setup * simplified creation * added readme.md file * added connection manager and id helper functions * Error handling & security updates (#744) * [Feature Request] New Features for Talawa-admin added (#725) * check authentication feature added for talawa admin * tests for check authentication added * minor fixes * typo fixes * minor fixes * npm err fixes * google recaptcha configured * new dependency added * mailer, forgotPassword endpoint and otp endpoint is configured * graphql endpoints updated * constants updated * Documentation updated * tests for changes added * hard coded value error fixes * lint fixes * lint fixes * failed test cases fixes * Failed tests fixes * minor fixes * marked-teminal dependency updated * Tests fixes * tests updated * tests fixes * tests updated * new resolvers added and schema updated * graphql mutations updated * tests updated for changes * tests updated * tests updated * tests updated * minor fixes * [Feature Request] : Plugin Architecture for Server (#730) * Test : lib/resolvers/group_chat_query/groupChatMessages.js * Add Test : Added Valid JSON Check * Create README.md * Create README.md * Update is-auth.js * AddedDocs Docs from withfilter pending * Update index.js * completed * sample * update/index.js * update/index.js * update/is-auth.js * Update/readme.md * update/image-readme * Add/query-schema * Update/Plugin-graphQL-schema * Add/Plugin-MongoDB-Model * Add/createPlugin-and-refractoring * Add/getPlugins * Add/Mutation/UpdatePluginStatus * Add/Mutation/updateTempPluginInstalledOrgs * Add/Mutation/Schema * Add/import/mutations * Add/plugins * Fix/path-err * Fix/Erros * update/lockfile * Add/plugin-model * Update is-auth.js * Removed extra queries * Documentation added for plugin queries and models * Fix/`delelte cr in prettier/prettier` * updated : mutation * Add/test `getPlugins` * Fix/`lint error` * test `updatePluginInstalledOrgs` * Test/ `updateInstallStatus` * Fix/Erros-1 * Fix/Erros-2 * Fix/Erros-3 * Test/`Queries.js` * Test/`Mutation.js` * remove extra `console.log` * Delete admin-plugin-query.js * Delete super-admin-plugin-query.js * Fix/Package-lock * added delimiter to helper functions * error handling for connection manager * added readme.md for connection manager * error handling for Database module Co-authored-by: Asmit Kumar Sirohi <[email protected]> Co-authored-by: Siddhesh Bhupendra Kuakde <[email protected]> * dynamic functionality additions * update tenant schema folder * modify all posts-comments resolvers * resolve failing tests for posts modifications * modify events-tasks-projects related resolvers * resolve failing tests * modified user queries * modify longin mutation to return events properly * modify org mutations and resolve failing tests * diconnect properly from the database * if not connection for org search in the database for it * group chats and direct chats mutations * remove console logs * remove unnecessary comments * fix drop database Co-authored-by: Mickey <[email protected]> Co-authored-by: Asmit Kumar Sirohi <[email protected]> Co-authored-by: Siddhesh Bhupendra Kuakde <[email protected]> Co-authored-by: JamaicanFriedChicken <[email protected]> * interchanged .env and .env.sample from the installation guide (#774) * Migrated develop branch to typescript including the changes till october 19, 2022 * Added some comments and reinstalled some packages to match the main repository's package.json * Github actions update * getLanguage.spec.ts import fix * forgotPassword.spec.ts fix Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Peter Harrison <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JamaicanFriedChicken <[email protected]> Co-authored-by: Siddhesh Bhupendra Kuakde <[email protected]> Co-authored-by: Nishant Singh <[email protected]> Co-authored-by: Nishant <[email protected]> Co-authored-by: Ebrahim <[email protected]> Co-authored-by: Mickey <[email protected]> Co-authored-by: Asmit Kumar Sirohi <[email protected]> Co-authored-by: Kanishka Bansode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Test
Issue Number:
Fixes #585
Did you add tests for your changes?
Yes
Snapshots/Videos:
If relevant, did you update the documentation?
added required docs in code
Summary
Added test to improve code coverage
Does this PR introduce a breaking change?
No
Other information
Not needed
Have you read the contributing guide?
Yes