From d003023d1bd0e6dc39f2cf5c50f41ee023b818df Mon Sep 17 00:00:00 2001 From: Tamim Khan Date: Mon, 28 Oct 2024 18:46:04 -0400 Subject: [PATCH 1/2] fix: fix pluginPackages type The value of `backstage.pluginPackages` is incorrectly set to `pluginId` when it is supposed to represent an array of all the packages that are a part of this plugin. This commit corrects this value to be an array and fixes an issue that prevents the installation of this plugin on certain backstage installations Signed-off-by: Tamim Khan --- package.json | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 611ed95..a6d5eae 100644 --- a/package.json +++ b/package.json @@ -10,13 +10,18 @@ "types": "dist/index.d.ts" }, "backstage": { - "pluginPackages": "pagerduty", - "pluginId": "backend", - "role": "backend-plugin" + "pluginId": "pagerduty", + "role": "backend-plugin", + "pluginPackages": [ + "@pagerduty/backstage-plugin", + "@pagerduty/backstage-plugin-common", + "@pagerduty/backstage-plugin-backend" + ] }, "repository": { "type": "git", - "url": "https://github.com/pagerduty/backstage-plugin-backend" + "url": "https://github.com/pagerduty/backstage-plugin-backend", + "directory": "." }, "homepage": "https://pagerduty.github.io/backstage-plugin-docs/index.html", "scripts": { From 2bcc770f9f2e2141782950fb68f6b63365be8575 Mon Sep 17 00:00:00 2001 From: Tamim Khan Date: Wed, 30 Oct 2024 10:58:55 -0400 Subject: [PATCH 2/2] fix: relax version pinning of @pagerduty/backstage-plugin-common In order to reduce the amount changes required to update dependent packages relax the version requirements for @pagerduty/backstage-plugin-common --- package.json | 2 +- yarn.lock | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index a6d5eae..573f74d 100644 --- a/package.json +++ b/package.json @@ -46,7 +46,7 @@ "@backstage/plugin-catalog-node": "^1.12.4", "@backstage/plugin-scaffolder-node": "^0.4.8", "@material-ui/core": "^4.12.4", - "@pagerduty/backstage-plugin-common": "0.2.1", + "@pagerduty/backstage-plugin-common": "^0.2.1", "@rjsf/core": "^5.14.3", "@types/express": "^4.17.6", "express": "^4.19.2", diff --git a/yarn.lock b/yarn.lock index 692c12f..bbeee95 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4752,7 +4752,7 @@ __metadata: "@backstage/plugin-catalog-node": ^1.12.4 "@backstage/plugin-scaffolder-node": ^0.4.8 "@material-ui/core": ^4.12.4 - "@pagerduty/backstage-plugin-common": 0.2.1 + "@pagerduty/backstage-plugin-common": ^0.2.1 "@rjsf/core": ^5.14.3 "@types/express": ^4.17.6 "@types/node": ^20.9.2 @@ -4776,7 +4776,7 @@ __metadata: languageName: unknown linkType: soft -"@pagerduty/backstage-plugin-common@npm:0.2.1": +"@pagerduty/backstage-plugin-common@npm:^0.2.1": version: 0.2.1 resolution: "@pagerduty/backstage-plugin-common@npm:0.2.1" checksum: 76233c2162d8e7bd3479e13652042cf949911be065f0bf92c5823cbc03c122b8ff49938ca36ab8449da800de7dd9c85724f70e3ff5323e77ef879478394115c9