[Hackathon 3rd No.27 and No.29 ] add paddle.incubate.sparse.any and paddle.incubate.sparse.sum #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OccupyMars2025
changed the title
zhwesky2010
reviewed
Sep 13, 2022
|
|
||
| 可以参考[torch.sparse.sum](https://pytorch.org/docs/stable/generated/torch.sparse.sum.html#torch.sparse.sum) | ||
| sum算子的python端的代码位于torch\sparse\__init__.py （line 153） | ||
| C++端的代码位于aten\src\ATen\native\sparse\SparseTensorMath.cpp (line 1515) |
There was a problem hiding this comment.
这里可以展开大致解读一下C++的代码，尤其是COO/CSR的支持情况 是否都支持，这里都可以展开说下
|
|
||
| ## tensorflow | ||
|
|
||
| 可以参考 [tf.sparse.reduce_sum](https://www.tensorflow.org/api_docs/python/tf/sparse/reduce_sum) 和 [tf.sparse.reduce_max](https://www.tensorflow.org/api_docs/python/tf/sparse/reduce_max) 的实现 |
| def max(x, axis=None, keepdim=False, name=None) | ||
| def min(x, axis=None, keepdim=False, name=None) | ||
| ``` | ||
| 考虑是否增加 output_is_sparse=False 这个参数 |
|
|
||
| # 附件及参考资料 | ||
|
|
||
| 本 RFC 参考了https://github.com/PaddlePaddle/community/pull/184，在这里对 |
| 静态图实现：目前sparse系列暂不支持静态图 | ||
|
|
||
| ```c | ||
| static PyObject* tensor_method_any(TensorObject* self, |
There was a problem hiding this comment.
这个实现既有前向，也有反向，不能像is_same_shape那样，那个返回的是一个bool值，没有构建反向网络 比较简单。这个必须要增加OP kernel
C++实现这里需要重写：kernel名、yaml名、大致算法
|
非常感谢飞桨专家的详细解答，我会尽快搞懂后修改提案。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.