Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.70】为神经网络编译器 CINN 增加 clip 算子 #194

Merged
merged 2 commits into from
Aug 10, 2022
Merged

【Hackathon No.70】为神经网络编译器 CINN 增加 clip 算子 #194

merged 2 commits into from
Aug 10, 2022

Conversation

zhangyuqin1998
Copy link
Contributor

add doc fot clip_op

@paddle-bot
Copy link

paddle-bot bot commented Aug 1, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备，具体请参考示例和模版。
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zhangyuqin1998 zhangyuqin1998 mentioned this pull request Aug 1, 2022
Closed
@Ligoml
Copy link
Contributor

Ligoml commented Aug 2, 2022

请参考其他pr修改下标题哈~

@zhangyuqin1998 zhangyuqin1998 changed the title add clip rfc 【Hackathon No.70】为神经网络编译器 CINN 增加 clip 算子 Aug 2, 2022
@zhangyuqin1998
Copy link
Contributor Author

请参考其他pr修改下标题哈~

好的已修改

zhhsplendid
zhhsplendid reviewed Aug 4, 2022
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

很好，别的地方我们没有什么问题了

rfcs/CINN/APIs/20220802_api_design_for_clip.md Outdated Show resolved Hide resolved
rfcs/CINN/APIs/20220802_api_design_for_clip.md Outdated Show resolved Hide resolved
zhhsplendid
zhhsplendid approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhhsplendid
zhhsplendid reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approve了，但是CLA好像PR提示还没签署。麻烦签署一下开源协议。签署一下，设计文档我们就可以合入了

@zhangyuqin1998
Copy link
Contributor Author

PR approve了，但是CLA好像PR提示还没签署。麻烦签署一下开源协议。签署一下，设计文档我们就可以合入了

好滴，已完成

zhhsplendid
zhhsplendid approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, 我这边可以合入设计文档

@zhhsplendid zhhsplendid merged commit 4c946c9 into PaddlePaddle:master Aug 10, 2022
@luotao1 luotao1 self-assigned this Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhhsplendid zhhsplendid zhhsplendid approved these changes

Assignees

@luotao1 luotao1

@zhhsplendid zhhsplendid

@Ligoml Ligoml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhangyuqin1998 @CLAassistant @Ligoml @zhhsplendid @luotao1