【Hackathon No.23】为 Paddle 新增 paddle.incubate.sparse.is_same_size 稀疏 API #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhwesky2010
reviewed
Jul 21, 2022
zhwesky2010
reviewed
Jul 25, 2022
There was a problem hiding this comment.
- API名
paddle.is_same_shape， 建议API实现放到 python/paddle/tensor/attribute.py 里，且动态图下直接类函数即可 - 动态图下：建议在 paddle/fluid/pybind/eager_method.cc 中实现，作为TensorObject的类成员函数，对比self.tensor.shape是否一致
- 目前不支持静态图，加装饰器@dygraph_only，描述不支持原因：静态图机制目前无法使用SparseCooTensor/SparseCsrTensor
- 单侧补充dense、coo、csr不同类型的9种组合情形
|
另外需要处理一下冲突 |
要判断的是shape还是size啊 |
|
|
|
按照后面review的来吧，这个任务是我写的最初版，后面详细review时会有一些细节改动 |
|
已更新 @zhouwei25 |
zhwesky2010
reviewed
Aug 3, 2022
| @@ -0,0 +1,88 @@ | |||
| # paddle.is_same_shape 设计文档 | |||
There was a problem hiding this comment.
你好，经过一些考虑，还是在python/paddle/incubate/sparse/multiary.py下实现吧，与dense区分下，API签名：paddle.incubate.sparse.is_same_shape。
|
|
||
| ## API实现方案 | ||
|
|
||
| 参考numpy实现，对比self.tensor.shape是否一致 |
There was a problem hiding this comment.
动态图实现：在 paddle/fluid/pybind/eager_method.cc 中实现，作为TensorObject的类成员函数，对比self.tensor.shape是否一致。
静态图实现：目前sparse系列暂不支持静态图
|
|
||
| ## 命名与参数设计 | ||
|
|
||
| 在 python/paddle/tensor/attribute.py 中新增api， |
There was a problem hiding this comment.
python/paddle/incubate/sparse/multiary.py
已更新 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.