Add putfiles command and add parse functions on controller.
#496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helinwang
reviewed
Nov 14, 2017
| } else if os.IsNotExist(pkgerr) { | ||
| return fmt.Errorf("stat jobpackage '%s' error: %v", jobPackage, pkgerr) | ||
| glog.Warning("jobpackage not a local dir, skip upload.") |
There was a problem hiding this comment.
Not a merge blocker, but maybe we can switch to log15 gradually?
There was a problem hiding this comment.
OK. Maybe we need an individual PR to fix this.
go/controller/controller.go
Outdated
| m := parser.ParseToMaster(job) | ||
|
|
||
| b, _ := json.MarshalIndent(p, "", " ") | ||
| log.Debug("create pserver:" + string(b[:])) |
There was a problem hiding this comment.
b instead of b[:] is more idiomatic.
go/controller/controller.go
Outdated
|
|
||
| // TODO(gongwb): create them | ||
| // just like: | ||
| // namespace := job.ObjectMeta.Namespace |
There was a problem hiding this comment.
Maybe put this code in your notes instead :)
go/controller/jobparser.go
Outdated
| // TODO: create job. | ||
| return &batchv1.Job{} | ||
| replicas := int32(job.Spec.Trainer.MinInstance) | ||
| command := make([]string, 2, 2) |
There was a problem hiding this comment.
This is same as make([]string, 2), which is typically used.
typhoonzero
reviewed
Nov 15, 2017
go/controller/jobparser.go
Outdated
| v1.Container{ | ||
| Name: "master", | ||
| Image: job.Spec.Image, | ||
| ImagePullPolicy: "Always", |
There was a problem hiding this comment.
ImagePullPolicy好几个地方都用到了，可以定义成一个const，或者启动参数
go/controller/jobparser.go
Outdated
| @@ -171,23 +297,42 @@ func podEnv(job *paddlejob.TrainingJob) []v1.EnvVar { | |||
| v1.EnvVar{Name: "PADDLE_INIT_NUM_GRADIENT_SERVERS", Value: strconv.Itoa(job.Spec.Trainer.MinInstance)}, | |||
| v1.EnvVar{Name: "PADDLE_INIT_NUM_PASSES", Value: strconv.Itoa(job.Spec.Passes)}, | |||
| v1.EnvVar{Name: "PADDLE_INIT_USE_GPU", Value: needGPU}, | |||
|
|
|||
| // FIXME(gongwb): LD_LIBRARY_PATH? | |||
There was a problem hiding this comment.
LD_LIBRARY_PATH需要用来增加CUDA相关库的目录
go/controller/jobparser.go
Outdated
| v1.Volume{ | ||
| Name: job.ObjectMeta.Name + "-workspace", | ||
| VolumeSource: v1.VolumeSource{ | ||
| HostPath: &v1.HostPathVolumeSource{ |
There was a problem hiding this comment.
Volume需要区分使用的文件系统：ceph, hostpath，还需要同时挂载用户目录和public目录
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #484