Fix log command error #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helinwang
reviewed
Jun 15, 2017
| @@ -53,7 +53,8 @@ func (p *LogsCommand) Execute(_ context.Context, f *flag.FlagSet, _ ...interface | |||
|
|
|||
| respBody, err := utils.GetCall(utils.Config.ActiveConfig.Endpoint+"/api/v1/logs", queryMap) | |||
| if err != nil { | |||
| fmt.Fprintf(os.Stderr, "call paddle cloud error %v", err) | |||
| fmt.Fprintf(os.Stderr, "call paddle cloud error %v, %v", err, respBody) | |||
There was a problem hiding this comment.
Maybe it's easier for viewing to print string instead of []byte, I could be wrong, because string could contain new line or strange characters which could break the log.
There was a problem hiding this comment.
Printing string or []byte can both use %s. Newline can also contain in a string which will affect the log printing
There was a problem hiding this comment.
I see, thanks! Did not know about %s can be used on []byte.
There was a problem hiding this comment.
Yes, I did. both %v and %s works for []byte
helinwang
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #145