MKLDNN pool2d OP kernel added #8879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzelazko-intel
force-pushed
the
fluid-mkldnn-pool
branch
from
ddeb663 to
1955297
Compare
pzelazko-intel
force-pushed
the
fluid-mkldnn-pool
branch
from
1955297 to
fbaea05
Compare
tensor-tang
reviewed
Mar 9, 2018
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ | ||
|
|
||
| #include "mkldnn.hpp" |
There was a problem hiding this comment.
mkldnn.hpp is included in mkldnn_helper.h.
Same as conv op.
| namespace operators { | ||
|
|
||
| template <typename T> | ||
| class PoolMkldnnKernel : public paddle::framework::OpKernel<T> { |
There was a problem hiding this comment.
I think this can be solved in this PR, since there are only two Kernels which should be renamed now.
There was a problem hiding this comment.
done
I additionally added commit with refactoring of mkldnn convolution to align to the pooling kernel style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MKLDNN pool2d OP kernels can be enabled with
use_mkldnnOP flag - just like currenly present use_cudnn flag. It's set toFalseby default.use_cudnnflag has figher priority.Beside unit tests, we validated these kernels by running training and interference on MNIST dataset and comparing results with caffe library.