Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 6th Fundable Projects 3 No.280】 [fluid_ops] pull_sparse #66022

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Jul 14, 2024

PR Category

Others

PR Types

Others

Description

删除 pull_sparse

Copy link

paddle-bot bot commented Jul 14, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jul 14, 2024
@co63oc co63oc changed the title 测试不review [fluid_ops] pull_sparse 【Hackathon 6th Fundable Projects 3 No.280】 [fluid_ops] pull_sparse Jul 14, 2024
wanghuancoder
wanghuancoder previously approved these changes Jul 15, 2024
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python/paddle/incubate/distributed/fleet/parameter_server/pslib/init.py
以及Python端可以检索一下pull_sparse,没有删干净。
另外,请 @luotao1 找分布式评估一下pull_sparse是否可以删除。

Copy link
Contributor

@danleifeng danleifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 1081f08 into PaddlePaddle:develop Jul 17, 2024
30 of 32 checks passed
@co63oc co63oc deleted the del_pull_sparse branch July 17, 2024 08:52
lixcli pushed a commit to lixcli/Paddle that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants