[CINN][New Hardware Update] standardize CINN_WITH_CUDA #64506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
tc20042008
approved these changes
May 23, 2024
tc20042008
reviewed
May 23, 2024
| #ifdef CINN_WITH_CUDA | ||
| optim::OptimizeExprGPU(&(funcs_after_schedule[i]->body)); | ||
| optim::OptimizeExprGPU(&(funcs_after_schedule[i]->body)); |
There was a problem hiding this comment.
既然ifdef CINN_WITH_CUDA都已经放到common::NVGPUArch这个alternative下了。最好把ifdef的else写全。
#ifdef CINN_WITH_CUDA
...
#else
CINN_NOT_IMPLEMENTED();
#endif
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
May 23, 2024
chen2016013
pushed a commit
to chen2016013/Paddle
that referenced
this pull request
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
增强以宏CINN_WITH_CUDA为条件的分支。
pcard-79890